This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4017

perfmoonwalk: make work with filtered repo
ClosedPublic

Authored by martinvonz on Aug 1 2018, 2:47 PM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHGa4d847cea6f8: perfmoonwalk: make work with filtered repo
rHG0848ed4ee7ac: perfmoonwalk: make work with filtered repo

Summary

This also fixes the out-of-range "len(repo)" that weirdly works (and
gets the nullid). I suspect it wasn't intentional to include the
timing of reading the null revision.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Aug 1 2018, 2:47 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptAug 1 2018, 2:47 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

martinvonz added a child revision: D4018: index: handle index[-1] as nullid more explicitly.Aug 1 2018, 2:47 PM

Closed by commit rHG0848ed4ee7ac: perfmoonwalk: make work with filtered repo (authored by martinvonz). · Explain WhyAug 1 2018, 3:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			contrib/perf.py (2 lines)

Status	Author	Revision
Closed	martinvonz	D4023 index: don't allow index[len(index)] to mean nullid
Closed	martinvonz	D4022 index: don't include nullid in len()
Closed	martinvonz	D4021 index: replace insert(-1, e) method by append(e) method
Closed	martinvonz	D4020 pure: create type for revlog v0 index
Closed	martinvonz	D4019 index: drop support for negative indexes into the index
Closed	martinvonz	D4018 index: handle index[-1] as nullid more explicitly
Closed	martinvonz	D4017 perfmoonwalk: make work with filtered repo
Closed	martinvonz	D4016 revlog: remove some knowledge of sentinel nullid in index
Closed	martinvonz	D4015 revlog: don't include trailing nullrev in revlog.revs(stop=len(revlog))

Diff 9729

contrib/perf.py

	@command('perfmoonwalk', formatteropts)			@command('perfmoonwalk', formatteropts)
	def perfmoonwalk(ui, repo, **opts):			def perfmoonwalk(ui, repo, **opts):
	"""benchmark walking the changelog backwards			"""benchmark walking the changelog backwards

	This also loads the changelog data for each revision in the changelog.			This also loads the changelog data for each revision in the changelog.
	"""			"""
	timer, fm = gettimer(ui, opts)			timer, fm = gettimer(ui, opts)
	def moonwalk():			def moonwalk():
	for i in xrange(len(repo), -1, -1):			for i in repo.changelog.revs(start=(len(repo) - 1), stop=-1):
	ctx = repo[i]			ctx = repo[i]
	ctx.branch() # read changelog data (in addition to the index)			ctx.branch() # read changelog data (in addition to the index)
	timer(moonwalk)			timer(moonwalk)
	fm.end()			fm.end()

	@command('perftemplating',			@command('perftemplating',
	[('r', 'rev', [], 'revisions to run the template on'),			[('r', 'rev', [], 'revisions to run the template on'),
	] + formatteropts)			] + formatteropts)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	9717		Aug 1 2018, 2:47 PM	★	★
Diff 2	9729	rHG0848ed4ee7ac833a9140a39758818bf33695dd16	Jul 20 2018, 2:37 PM	★	★