Page MenuHomePhabricator

revlog: remove some knowledge of sentinel nullid in index
ClosedPublic

Authored by martinvonz on Aug 1 2018, 2:47 PM.

Details

Summary

I think the "-2" to mean "last position in index, not counting the
null revision at the end" is an implementation detail of the index
that we should avoid spreading knowledge of. I hope we can even remove
support for index[-2].

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Aug 1 2018, 2:47 PM
martinvonz updated this revision to Diff 9776.Aug 2 2018, 12:40 AM
This revision was automatically updated to reflect the committed changes.