Page MenuHomePhabricator

index: replace insert(-1, e) method by append(e) method
ClosedPublic

Authored by martinvonz on Aug 1 2018, 2:47 PM.

Details

Summary

I want to make index[len(index) - 1] be the tip revision, not null
revision as it is today. insert(-1, e) will then make little
sense. Since insert() currently requires the first argument to be -1,
it seems simpler to replace it by a method that allows insertion only
at the end.

Note that revlogoldindex already has this method (by virtue of
extending list).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Aug 1 2018, 2:47 PM
martinvonz updated this revision to Diff 9780.Aug 2 2018, 12:40 AM
martinvonz updated this revision to Diff 9884.Aug 4 2018, 12:20 AM
yuja added a subscriber: yuja.Aug 4 2018, 2:41 AM

Bumped cext version and queued, thanks.

This revision was automatically updated to reflect the committed changes.