This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4048

fix: add a monkey-patchable point after all new revisions have been committed
ClosedPublic

Authored by hooper on Aug 1 2018, 7:03 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG64535d43c103: fix: add a monkey-patchable point after all new revisions have been committed

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

hooper created this revision.Aug 1 2018, 7:03 PM
hooper updated this revision to Diff 9769.Aug 1 2018, 7:13 PM
pulkit accepted this revision.Aug 2 2018, 6:25 PM
pulkit added a subscriber: pulkit.
pulkit added inline comments.
hgext/fix.py
197

If the output is not Google specific, we can have that here also under hg fix -v or a config option.

Closed by commit rHG64535d43c103: fix: add a monkey-patchable point after all new revisions have been committed (authored by hooper). · Explain WhyAug 2 2018, 6:50 PM
This revision was automatically updated to reflect the committed changes.
hooper added inline comments.Aug 3 2018, 5:21 PM
hgext/fix.py
197

Unfortunately, some of it is, though that might just mean we should template it. I think there's also some difficulty around verbosity levels if you don't want to see other modules' verbose output? At the very least I think "hg fix -q" should have no output if it succeeds.

Revision Contents
Changeset List

PathPackages
Mhgext/fix.py (16 lines)

Diff 9768

hgext/fix.py

rev = commitorder.pop() rev = commitorder.pop()
ctx = repo[rev] ctx = repo[rev]
if rev == wdirrev: if rev == wdirrev:
writeworkingdir(repo, ctx, filedata[rev], replacements) writeworkingdir(repo, ctx, filedata[rev], replacements)
else: else:
replacerev(ui, repo, ctx, filedata[rev], replacements) replacerev(ui, repo, ctx, filedata[rev], replacements)
del filedata[rev] del filedata[rev]
cleanup(repo, replacements)
def cleanup(repo, replacements):
"""Calls scmutil.cleanupnodes() with the given replacements.
"replacements" is a dict from nodeid to nodeid, with one key and one value
for every revision that was affected by fixing. This is slightly different
from cleanupnodes().
Useful as a hook point for extending "hg fix" with output summarizing the
effects of the command, though we choose not to output anything here.
"""
replacements = {prec: [succ] for prec, succ in replacements.iteritems()} replacements = {prec: [succ] for prec, succ in replacements.iteritems()}
pulkitUnsubmitted
Not Done

If the output is not Google specific, we can have that here also under hg fix -v or a config option.

pulkit: If the output is not Google specific, we can have that here also under `hg fix -v` or a config…
hooperAuthorUnsubmitted
Not Done

Unfortunately, some of it is, though that might just mean we should template it. I think there's also some difficulty around verbosity levels if you don't want to see other modules' verbose output? At the very least I think "hg fix -q" should have no output if it succeeds.

hooper: Unfortunately, some of it is, though that might just mean we should template it. I think…
scmutil.cleanupnodes(repo, replacements, 'fix', fixphase=True) scmutil.cleanupnodes(repo, replacements, 'fix', fixphase=True)
def getworkqueue(ui, repo, pats, opts, revstofix, basectxs): def getworkqueue(ui, repo, pats, opts, revstofix, basectxs):
""""Constructs the list of files to be fixed at specific revisions """"Constructs the list of files to be fixed at specific revisions
It is up to the caller how to consume the work items, and the only It is up to the caller how to consume the work items, and the only
dependence between them is that replacement revisions must be committed in dependence between them is that replacement revisions must be committed in
topological order. Each work item represents a file in the working copy or topological order. Each work item represents a file in the working copy or
in some revision that should be fixed and written back to the working copy in some revision that should be fixed and written back to the working copy