This is an archive of the discontinued Mercurial Phabricator instance.

narrowspec: use sparse.parseconfig() to parse narrowspec file (BC)
ClosedPublic

Authored by pulkit on Aug 2 2018, 3:52 PM.

Details

Summary

This also make narrow files use 'include' and 'exclude' instead of plural forms
which are 'includes' and 'excludes'.

This is BC because existing narrowspecs have to replace excludes, includes words
with exclude and include i.e. their singular versions.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Aug 2 2018, 3:52 PM
martinvonz added inline comments.
mercurial/narrowspec.py
143–149

We should at least abort if they're in there. I think we should add that check already in this patch.

martinvonz requested changes to this revision.Aug 2 2018, 5:03 PM
This revision now requires changes to proceed.Aug 2 2018, 5:03 PM
pulkit edited the summary of this revision. (Show Details)Aug 3 2018, 12:55 PM
pulkit retitled this revision from narrowspec: use sparse.parseconfig() to parse narrowspec file (BC) to narrowspec: use sparse.parseconfig() to parse narrowspec file.
pulkit updated this revision to Diff 9829.
pulkit marked an inline comment as done.Aug 3 2018, 12:56 PM
pulkit edited the summary of this revision. (Show Details)Aug 3 2018, 12:59 PM
pulkit retitled this revision from narrowspec: use sparse.parseconfig() to parse narrowspec file to narrowspec: use sparse.parseconfig() to parse narrowspec file (BC).
martinvonz accepted this revision.Aug 3 2018, 1:05 PM
martinvonz added inline comments.
mercurial/narrowspec.py
145

I'll rename this to profiles in flight

This revision is now accepted and ready to land.Aug 3 2018, 1:05 PM

I've rebased this on top of D4093 and resolved the conflicts (simply drop the changes from this patch). I'll push it once tests have finished.

This revision was automatically updated to reflect the committed changes.