This is an archive of the discontinued Mercurial Phabricator instance.

changegroup: move revchunk() from narrow
ClosedPublic

Authored by indygreg on Aug 2 2018, 5:15 PM.

Details

Summary

The monkeypatched revchunk for ellipses serving is a
completely independent implementation. We model it as such
in the changegroup code. revchunk() is now a simple proxy
function.

Again, I wish we had better APIs here. Especially since this
narrow code is part of cg1packer and cg1packer can't be used
with narrow. Class inheritance is wonky. And I will definitely
be making changes to changegroup code for delta generation.

As part of the code move, node.nullrev was replaced by
nullrev. And a reference to orig was replaced to call
self._revchunknormal directly.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Aug 2 2018, 5:15 PM
This revision was automatically updated to reflect the committed changes.