This is an archive of the discontinued Mercurial Phabricator instance.

Differential D408

remotefilelog: gc option for repacker class
ClosedPublic

Authored by ms2316 on Aug 15 2017, 7:02 AM.
Tags
None
Subscribers
None

Details

Reviewers
ryanmce
durham
simonfar
Group Reviewers
Restricted Project
Commits
rFBHGX2d9aa19287c9: remotefilelog: gc option for repacker class
Summary

Repack is also used for repack of local trees, which should not be garbage
collected. Therefore, we want to be able to pass the gc option to the repacker
class so that we could garbage collect the shared cache but not local trees.

Test Plan
  • Run unit tests
  • Test manually on www repo

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ms2316 created this revision.Aug 15 2017, 7:02 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 15 2017, 7:02 AM
ryanmce edited edge metadata.Aug 15 2017, 7:14 AM

Why is this better?

ms2316 edited the summary of this revision. (Show Details)Aug 15 2017, 7:30 AM
ms2316 updated this revision to Diff 928.

Updated summary

ryanmce accepted this revision.Aug 15 2017, 7:31 AM
This revision is now accepted and ready to land.Aug 15 2017, 7:31 AM
Closed by commit rFBHGX2d9aa19287c9: remotefilelog: gc option for repacker class (authored by ms2316). · Explain WhyAug 16 2017, 11:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mremotefilelog/repack.py (8 lines)

Diff 990

remotefilelog/repack.py

# Currently default TTL limit is 30 days # Currently default TTL limit is 30 days
defaultlimit = 60 * 60 * 24 * 30 defaultlimit = 60 * 60 * 24 * 30
ttl = repo.ui.configint('remotefilelog', 'nodettl', defaultlimit) ttl = repo.ui.configint('remotefilelog', 'nodettl', defaultlimit)
limit = time.time() - ttl limit = time.time() - ttl
return filetime[0] < limit return filetime[0] < limit
packer = repacker(repo, data, history, category, isold) garbagecollect = repo.ui.configbool('remotefilelog', 'gcrepack')
packer = repacker(repo, data, history, category, gc=garbagecollect,
isold=isold)
# internal config: remotefilelog.datapackversion # internal config: remotefilelog.datapackversion
dv = repo.ui.configint('remotefilelog', 'datapackversion', 0) dv = repo.ui.configint('remotefilelog', 'datapackversion', 0)
with datapack.mutabledatapack(repo.ui, packpath, version=dv) as dpack: with datapack.mutabledatapack(repo.ui, packpath, version=dv) as dpack:
with historypack.mutablehistorypack(repo.ui, packpath) as hpack: with historypack.mutablehistorypack(repo.ui, packpath) as hpack:
try: try:
packer.run(dpack, hpack) packer.run(dpack, hpack)
except error.LockHeld: except error.LockHeld:
raise error.Abort(_("skipping repack - another repack is " raise error.Abort(_("skipping repack - another repack is "
"already running")) "already running"))
class repacker(object): class repacker(object):
"""Class for orchestrating the repack of data and history information into a """Class for orchestrating the repack of data and history information into a
new format. new format.
""" """
def __init__(self, repo, data, history, category, isold=None): def __init__(self, repo, data, history, category, gc=False, isold=None):
self.repo = repo self.repo = repo
self.data = data self.data = data
self.history = history self.history = history
self.unit = constants.getunits(category) self.unit = constants.getunits(category)
self.garbagecollect = repo.ui.configbool('remotefilelog', 'gcrepack') self.garbagecollect = gc
if self.garbagecollect: if self.garbagecollect:
if not isold: if not isold:
raise ValueError("Function 'isold' is not properly specified") raise ValueError("Function 'isold' is not properly specified")
self.keepkeys = self._gckeepset() self.keepkeys = self._gckeepset()
self.isold = isold self.isold = isold
def _gckeepset(self): def _gckeepset(self):
"""Computes a keepset which is not garbage collected. """Computes a keepset which is not garbage collected.