This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4149

linelog: extract `len(self._program)` to a local function
ClosedPublic

Authored by quark on Aug 6 2018, 10:00 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG32b1967b8734: linelog: extract `len(self._program)` to a local function
Summary

This is a micro optimization prepared for following changes where
len(self._program) is used in a loop.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Aug 6 2018, 10:00 PM
quark updated this revision to Diff 10026.Aug 6 2018, 10:04 PM
indygreg accepted this revision.Aug 7 2018, 7:33 PM
This revision is now accepted and ready to land.Aug 7 2018, 7:33 PM
quark updated this revision to Diff 10066.Aug 7 2018, 8:22 PM
Closed by commit rHG32b1967b8734: linelog: extract `len(self._program)` to a local function (authored by quark). · Explain WhyAug 9 2018, 2:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/linelog.py (3 lines)

Diff 10134

mercurial/linelog.py

elif a1 == len(ar.lines): elif a1 == len(ar.lines):
# Simulated EOF instruction since we're at EOF, which # Simulated EOF instruction since we're at EOF, which
# doesn't have a "real" line. # doesn't have a "real" line.
a1inst = _eof(0, 0) a1inst = _eof(0, 0)
a1info = lineinfo(0, 0, ar._eof) a1info = lineinfo(0, 0, ar._eof)
else: else:
a1info = ar.lines[a1] a1info = ar.lines[a1]
a1inst = self._program[a1info._offset] a1inst = self._program[a1info._offset]
oldproglen = len(self._program) programlen = self._program.__len__
oldproglen = programlen()
appendinst = self._program.append appendinst = self._program.append
# insert # insert
if b1 < b2: if b1 < b2:
# Determine the jump target for the JGE at the start of # Determine the jump target for the JGE at the start of
# the new block. # the new block.
tgt = oldproglen + (b2 - b1 + 1) tgt = oldproglen + (b2 - b1 + 1)
# Jump to skip the insert if we're at an older revision. # Jump to skip the insert if we're at an older revision.