| indygreg |
| hg-reviewers |
This is a micro optimization prepared for following changes where
len(self._program) is used in a loop.
| Lint Skipped |
| Unit Tests Skipped |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/linelog.py (3 lines) |
| # which we're editing as well as a revision to mark | # which we're editing as well as a revision to mark | ||||
| # responsible for the edits. In hg-experimental it's | # responsible for the edits. In hg-experimental it's | ||||
| # stateful like this, so we're doing the same thing to | # stateful like this, so we're doing the same thing to | ||||
| # retain compatibility with absorb until that's imported. | # retain compatibility with absorb until that's imported. | ||||
| ar = self._lastannotate | ar = self._lastannotate | ||||
| else: | else: | ||||
| ar = self.annotate(rev) | ar = self.annotate(rev) | ||||
| # ar = self.annotate(self._maxrev) | # ar = self.annotate(self._maxrev) | ||||
| programlen = self._program.__len__ | |||||
| if a1 > len(ar.lines): | if a1 > len(ar.lines): | ||||
| raise LineLogError( | raise LineLogError( | ||||
| '%d contains %d lines, tried to access line %d' % ( | '%d contains %d lines, tried to access line %d' % ( | ||||
| rev, len(ar.lines), a1)) | rev, len(ar.lines), a1)) | ||||
| elif a1 == len(ar.lines): | elif a1 == len(ar.lines): | ||||
| # Simulated EOF instruction since we're at EOF, which | # Simulated EOF instruction since we're at EOF, which | ||||
| # doesn't have a "real" line. | # doesn't have a "real" line. | ||||
| a1inst = _eof(0, 0) | a1inst = _eof(0, 0) | ||||
| a1info = lineinfo(0, 0, ar._eof) | a1info = lineinfo(0, 0, ar._eof) | ||||
| else: | else: | ||||
| a1info = ar.lines[a1] | a1info = ar.lines[a1] | ||||
| a1inst = self._program[a1info._offset] | a1inst = self._program[a1info._offset] | ||||
| oldproglen = len(self._program) | oldproglen = programlen() | ||||
| appendinst = self._program.append | appendinst = self._program.append | ||||
| # insert | # insert | ||||
| if b1 < b2: | if b1 < b2: | ||||
| # Determine the jump target for the JGE at the start of | # Determine the jump target for the JGE at the start of | ||||
| # the new block. | # the new block. | ||||
| tgt = oldproglen + (b2 - b1 + 1) | tgt = oldproglen + (b2 - b1 + 1) | ||||
| # Jump to skip the insert if we're at an older revision. | # Jump to skip the insert if we're at an older revision. | ||||