This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4167

narrow: add '()' to ellipsis in the revset help
ClosedPublic

Authored by pulkit on Aug 9 2018, 6:18 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG05ded838c997: narrow: add '()' to ellipsis in the revset help
Summary

ellipsis is a revset function and was missing () after it's name in the help
text. This might confuse users as they try hg log -r 'ellipsis'.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Aug 9 2018, 6:18 AM
Closed by commit rHG05ded838c997: narrow: add '()' to ellipsis in the revset help (authored by pulkit). · Explain WhyAug 9 2018, 2:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/narrow/narrowtemplates.py (2 lines)

Diff 10128

hgext/narrow/narrowtemplates.py

repo = context.resource(mapping, 'repo') repo = context.resource(mapping, 'repo')
ctx = context.resource(mapping, 'ctx') ctx = context.resource(mapping, 'ctx')
m = repo.narrowmatch() m = repo.narrowmatch()
if not m.always(): if not m.always():
if not any(m(f) for f in ctx.files()): if not any(m(f) for f in ctx.files()):
return 'outsidenarrow' return 'outsidenarrow'
return '' return ''
@revsetpredicate('ellipsis') @revsetpredicate('ellipsis()')
def ellipsisrevset(repo, subset, x): def ellipsisrevset(repo, subset, x):
"""Changesets that are ellipsis nodes.""" """Changesets that are ellipsis nodes."""
return subset.filter(lambda r: _isellipsis(repo, r)) return subset.filter(lambda r: _isellipsis(repo, r))