This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4179

tests: move assertion closer to want/got declarations in test-parseindex2.py
ClosedPublic

Authored by durin42 on Aug 9 2018, 1:42 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG94cff858b4e5: tests: move assertion closer to want/got declarations in test-parseindex2.py
Summary

I find this easier to understand.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mtests/test-parseindex2.py (3 lines)

Diff 10170

tests/test-parseindex2.py

def testparseindexfile(self): def testparseindexfile(self):
# Check parsers.parse_index2() on an index file against the # Check parsers.parse_index2() on an index file against the
# original Python implementation of parseindex, both with and # original Python implementation of parseindex, both with and
# without inlined data. # without inlined data.
py_res_1 = py_parseindex(data_inlined, True) py_res_1 = py_parseindex(data_inlined, True)
c_res_1 = parse_index2(data_inlined, True) c_res_1 = parse_index2(data_inlined, True)
self.assertEqual(py_res_1, c_res_1) # inline data
py_res_2 = py_parseindex(data_non_inlined, False) py_res_2 = py_parseindex(data_non_inlined, False)
c_res_2 = parse_index2(data_non_inlined, False) c_res_2 = parse_index2(data_non_inlined, False)
self.assertEqual(py_res_1, c_res_1) # inline data
self.assertEqual(py_res_2, c_res_2) # no inline data self.assertEqual(py_res_2, c_res_2) # no inline data
ix = parsers.parse_index2(data_inlined, True)[0] ix = parsers.parse_index2(data_inlined, True)[0]
for i, r in enumerate(ix): for i, r in enumerate(ix):
if r[7] == nullid: if r[7] == nullid:
i = -1 i = -1
try: try:
self.assertEqual( self.assertEqual(