This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4182

tests: restore Python 3 compat in test-parseindex2.py
ClosedPublic

Authored by durin42 on Aug 9 2018, 1:42 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa450d460774e: tests: restore Python 3 compat in test-parseindex2.py
Summary

I think this was previously getting lucky in Python 3, and would have
stacktraced if something failed. Now that failure messages are eagerly
computed, this turned into a problem.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Aug 9 2018, 1:42 PM
durin42 updated this revision to Diff 10125.Aug 9 2018, 1:46 PM
pulkit accepted this revision.Aug 10 2018, 8:05 AM
Closed by commit rHGa450d460774e: tests: restore Python 3 compat in test-parseindex2.py (authored by durin42). · Explain WhyAug 10 2018, 8:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-parseindex2.py (3 lines)

Diff 10291

tests/test-parseindex2.py

import sys import sys
import unittest import unittest
from mercurial.node import ( from mercurial.node import (
nullid, nullid,
nullrev, nullrev,
) )
from mercurial import ( from mercurial import (
node as nodemod,
policy, policy,
pycompat, pycompat,
) )
parsers = policy.importmod(r'parsers') parsers = policy.importmod(r'parsers')
# original python implementation # original python implementation
def gettype(q): def gettype(q):
ix = parsers.parse_index2(data_inlined, True)[0] ix = parsers.parse_index2(data_inlined, True)[0]
for i, r in enumerate(ix): for i, r in enumerate(ix):
if r[7] == nullid: if r[7] == nullid:
i = -1 i = -1
try: try:
self.assertEqual( self.assertEqual(
ix[r[7]], i, ix[r[7]], i,
'Reverse lookup inconsistent for %r' % r[7].encode('hex')) 'Reverse lookup inconsistent for %r' % nodemod.hex(r[7]))
except TypeError: except TypeError:
# pure version doesn't support this # pure version doesn't support this
break break
if __name__ == '__main__': if __name__ == '__main__':
import silenttestrunner import silenttestrunner
silenttestrunner.main(__name__) silenttestrunner.main(__name__)
print("done") print("done")