This is an archive of the discontinued Mercurial Phabricator instance.

patchbomb: don't unintentionally duplicate headers
ClosedPublic

Authored by durin42 on Aug 9 2018, 10:06 PM.

Details

Summary

This dict-like of headers is only mostly dict-like: if you set a key
that already exists, you it appends another value, rather than
replacing the one that was already present.

This fixes test-patchbomb-bookmark.t on Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Aug 9 2018, 10:06 PM
indygreg accepted this revision.Aug 9 2018, 11:20 PM
indygreg added a subscriber: indygreg.

Eww. But I got nothing better that doesn't involve reconstructing the message instance :/

This revision is now accepted and ready to land.Aug 9 2018, 11:20 PM
This revision was automatically updated to reflect the committed changes.