This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4269

changegroup: call rev() on manifestlog instance
ClosedPublic

Authored by indygreg on Aug 13 2018, 12:55 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGa79279a21b0a: changegroup: call rev() on manifestlog instance
Summary

rev() is part of the imanifestlog interface and should be used instead
of using the private revlog instance, which is an implementation
detail.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 13 2018, 12:55 PM
Closed by commit rHGa79279a21b0a: changegroup: call rev() on manifestlog instance (authored by indygreg). · Explain WhyAug 22 2018, 12:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/changegroup.py (4 lines)

Diff 10515

mercurial/changegroup.py

Returns a 2-tuple of a dict containing state and an iterable of Returns a 2-tuple of a dict containing state and an iterable of
byte chunks. The state will not be fully populated until the byte chunks. The state will not be fully populated until the
chunk stream has been fully consumed. chunk stream has been fully consumed.
""" """
clrevorder = {} clrevorder = {}
mfs = {} # needed manifests mfs = {} # needed manifests
mfl = self._repo.manifestlog mfl = self._repo.manifestlog
# TODO violates storage abstraction.
mfrevlog = mfl._revlog
changedfiles = set() changedfiles = set()
clrevtomanifestrev = {} clrevtomanifestrev = {}
# Callback for the changelog, used to collect changed files and # Callback for the changelog, used to collect changed files and
# manifest nodes. # manifest nodes.
# Returns the linkrev node (identity in the changelog case). # Returns the linkrev node (identity in the changelog case).
def lookupcl(x): def lookupcl(x):
c = cl.read(x) c = cl.read(x)
n = c[0] n = c[0]
# Record the first changeset introducing this manifest # Record the first changeset introducing this manifest
# version. # version.
mfs.setdefault(n, x) mfs.setdefault(n, x)
# Set this narrow-specific dict so we have the lowest # Set this narrow-specific dict so we have the lowest
# manifest revnum to look up for this cl revnum. (Part of # manifest revnum to look up for this cl revnum. (Part of
# mapping changelog ellipsis parents to manifest ellipsis # mapping changelog ellipsis parents to manifest ellipsis
# parents) # parents)
clrevtomanifestrev.setdefault(cl.rev(x), mfrevlog.rev(n)) clrevtomanifestrev.setdefault(cl.rev(x), mfl.rev(n))
# We can't trust the changed files list in the changeset if the # We can't trust the changed files list in the changeset if the
# client requested a shallow clone. # client requested a shallow clone.
if self._isshallow: if self._isshallow:
changedfiles.update(mfl[c[0]].read().keys()) changedfiles.update(mfl[c[0]].read().keys())
else: else:
changedfiles.update(c[3]) changedfiles.update(c[3])
else: else: