This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4273

repository: clarify role of imanifestlog
ClosedPublic

Authored by indygreg on Aug 13 2018, 12:55 PM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHG2af6b2d8d1d8: repository: clarify role of imanifestlog

Summary

Looking at the implementation of manifest.manifestlog, it is highly
tailored towards servicing the root manifest. So clarify that in the
interface docstring.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 13 2018, 12:55 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptAug 13 2018, 12:55 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

indygreg added a child revision: D4274: manifest: remove addgroup() from manifestlog and imanifestlog.Aug 13 2018, 12:55 PM

Closed by commit rHG2af6b2d8d1d8: repository: clarify role of imanifestlog (authored by indygreg). · Explain WhyAug 22 2018, 12:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/repository.py (8 lines)

Status	Author	Revision
Closed	indygreg	D4279 manifest: use rev() instead of nodemap.__contains__
Closed	indygreg	D4278 manifest: rename manifestlog._treeinmem to ._treemanifests
Closed	indygreg	D4277 manifest: add getstorage() to manifestlog and use it globally
Closed	indygreg	D4276 manifest: rename dir argument and attribute to tree
Closed	indygreg	D4275 manifest: set appropriate cache entry when clearing _dirlogcache()
Closed	indygreg	D4274 manifest: remove addgroup() from manifestlog and imanifestlog
Closed	indygreg	D4273 repository: clarify role of imanifestlog
Closed	indygreg	D4272 changegroup: change topics during generation
Closed	indygreg	D4271 changegroup: rename mfs to manifests
Closed	indygreg	D4270 changegroup: clean up changelog callback
Closed	indygreg	D4269 changegroup: call rev() on manifestlog instance
Closed	indygreg	D4268 manifest: rename dir to tree to avoid shadowing built-in
Closed	indygreg	D4236 repository: remove candelta() from ifileindex
Closed	indygreg	D4235 changegroup: rename dir to tree to avoid shadowing a built-in
Closed	indygreg	D4227 repository: remove storedeltachains from ifilestorage
Closed	indygreg	D4226 repository: establish API for emitting revision deltas
Closed	indygreg	D4225 repository: formalize interfaces for revision deltas and requests
Closed	indygreg	D4224 changegroup: move node sorting into deltagroup()
Closed	indygreg	D4217 changegroup: invert conditional and dedent
Closed	indygreg	D4216 changegroup: capture base node instead of rev in delta request
Closed	indygreg	D4215 changegroup: introduce requests to define delta generation
Closed	indygreg	D4214 changegroup: refactor delta parent code
Closed	indygreg	D4213 changegroup: differentiate between fulltext and diff based deltas
Closed	indygreg	D4212 changegroup: minor cleanups to deltagroup()
Closed	indygreg	D4211 changegroup: emit revisiondelta instances from deltagroup()
Closed	indygreg	D4210 changegroup: move file chunk emission to generate()
Closed	indygreg	D4209 changegroup: move manifest chunk emission to generate()
Closed	indygreg	D4208 changegroup: move size tracking and end of manifests to generate()
Closed	indygreg	D4207 changegroup: emit delta group close chunk outside of deltagroup()
Closed	indygreg	D4206 changegroup: extract cgpacker.group() to standalone function
Closed	indygreg	D4205 changegroup: pass all state into group()
Closed	indygreg	D4199 changegroup: inline _prune() into call sites
Closed	indygreg	D4198 changegroup: inline _packmanifests() into generatemanifests()
Closed	indygreg	D4197 changegroup: invert conditional and dedent
Closed	indygreg	D4196 changegroup: make _revisiondeltanarrow() a standalone function
Closed	indygreg	D4195 changegroup: pass state into _revisiondeltanarrow
Closed	indygreg	D4194 changegroup: inline _close()
Closed	indygreg	D4193 changegroup: pass clrevtolocalrev to each group
Closed	indygreg	D4192 changegroup: combine _generatefiles() into generatefiles()
Closed	indygreg	D4191 changegroup: define linknodes callbacks in generatefiles()
Closed	indygreg	D4190 changegroup: track changelog to manifest revision map explicitly
Closed	indygreg	D4189 changegroup: remove _clnodetorev
Closed	indygreg	D4188 changegroup: rename _fullnodes to _fullclnodes
Closed	indygreg	D4187 changegroup: move part of _revisiondeltanarrow into group()
Closed	indygreg	D4186 changegroup: populate _clnodetorev as part of changelog linknode lookup
Closed	indygreg	D4142 changegroup: extract _revisiondeltanormal() to standalone function
Closed	indygreg	D4141 changegroup: inline _revchunk() into group()
Closed	indygreg	D4140 changegroup: pass mfdicts properly
Closed	indygreg	D4139 changegroup: pass sorted revisions into group() (API)
Closed	indygreg	D4138 changegroup: pull _fileheader out of cgpacker
Closed	indygreg	D4137 changegroup: factor changelogdone into an argument
Closed	indygreg	D4136 changegroup: record changelogdone after fully consuming its data
Closed	indygreg	D4135 changegroup: key off changelogdone
Closed	indygreg	D4134 perf: call _generatechangelog() instead of group()
Closed	indygreg	D4133 changegroup: factor changelog chunk generation into own function
Closed	indygreg	D4132 changegroup: pass function to resolve delta parents into constructor
Closed	indygreg	D4155 changegroup: restore original behavior of _nextclrevtolocalrev

Diff 10520

mercurial/repository.py

	Takes a transaction object, the changeset revision number it will			Takes a transaction object, the changeset revision number it will
	be associated with, its parent nodes, and lists of added and			be associated with, its parent nodes, and lists of added and
	removed paths.			removed paths.

	Returns the binary node of the created revision.			Returns the binary node of the created revision.
	"""			"""

	class imanifestlog(interfaceutil.Interface):			class imanifestlog(interfaceutil.Interface):
	"""Interface representing a collection of manifest snapshots."""			"""Interface representing a collection of manifest snapshots.

				Represents the root manifest in a repository.

				Also serves as a means to access nested tree manifests and to cache
				tree manifests.
				"""

	def __getitem__(node):			def __getitem__(node):
	"""Obtain a manifest instance for a given binary node.			"""Obtain a manifest instance for a given binary node.

	Equivalent to calling ``self.get('', node)``.			Equivalent to calling ``self.get('', node)``.

	The returned object conforms to the ``imanifestrevisionstored``			The returned object conforms to the ``imanifestrevisionstored``
	interface.			interface.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	10345		Aug 13 2018, 12:55 PM	★	★
Diff 2	10520	rHG2af6b2d8d1d823fb57b1d6363aae7858d9d17c98	Aug 10 2018, 4:59 PM	★	★