This is an archive of the discontinued Mercurial Phabricator instance.

manifest: rename manifestlog._treeinmem to ._treemanifests
ClosedPublic

Authored by indygreg on Aug 13 2018, 12:55 PM.

Details

Summary

Not sure what "inmem" was supposed to indicate. This object is an
interface to manifest data on disk as well as "in memory" (assuming
that's what "inmem" means).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 13 2018, 12:55 PM

We used to have a way to do tree-in-memory but flat-on-disk, IIRC.

This revision was automatically updated to reflect the committed changes.
martinvonz added inline comments.
mercurial/manifest.py
1275

_treeinmem was used for indicating that the treemanifest type should be used in memory and this variable (_treeondisk) was used for indicating that treemanifest revlogs should be used. The only reason this distinction was useful was so you could set manually force _treeinmem = True in the code and run the test suite to make sure that the treemanifest type worked.