This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4361

zsh_completion: complete hg files
ClosedPublic

Authored by av6 on Aug 23 2018, 3:44 AM.

Details

Reviewers
spectral
Group Reviewers
hg-reviewers
Commits
rHGad1c6bd3c676: zsh_completion: complete hg files
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

av6 created this revision.Aug 23 2018, 3:44 AM
spectral accepted this revision.Aug 29 2018, 2:24 PM
spectral added a subscriber: spectral.

(Accept conditional on fixing/documenting the difference I noticed)

contrib/zsh_completion
636

This is "search the repository as it is in REV" in my version (545a3e6650cd) and at default head (6f38284b)

pulkit added a subscriber: pulkit.Aug 29 2018, 3:14 PM

Queued this and D4360 as per spectral review. Many thanks!

contrib/zsh_completion
636

I changed "revision" to "REV" in flight.

Closed by commit rHGad1c6bd3c676: zsh_completion: complete hg files (authored by av6). · Explain WhyAug 29 2018, 3:41 PM
This revision was automatically updated to reflect the committed changes.
av6 added inline comments.Aug 30 2018, 1:14 AM
contrib/zsh_completion
636

What is REV? It's a metavariable used in hg help output. It makes sense if you look at the help output while typing up hg files, but zsh's completion is supposed to help users to not constantly look at help/info/man, and here and throughout the completion file the metavariable is "revision".

Actually, looks like even hg help output most of the time spells out "revision" or "changeset" instead of using metavariables.

Revision Contents
Changeset List

PathPackages
Mcontrib/zsh_completion (7 lines)

Diff 10650

contrib/zsh_completion

_hg_cmd_export() { _hg_cmd_export() {
_arguments -s -S : $_hg_global_opts $_hg_diff_opts \ _arguments -s -S : $_hg_global_opts $_hg_diff_opts \
'(--output -o)'{-o+,--output=}'[print output to file with formatted name]:format string' \ '(--output -o)'{-o+,--output=}'[print output to file with formatted name]:format string' \
'--switch-parent[diff against the second parent]' \ '--switch-parent[diff against the second parent]' \
'*'{-r+,--rev=}'[revisions to export]:revision:_hg_labels' \ '*'{-r+,--rev=}'[revisions to export]:revision:_hg_labels' \
'*:revision:_hg_labels' '*:revision:_hg_labels'
} }
_hg_cmd_files() {
_arguments -s -S : $_hg_global_opts $_hg_pat_opts $_hg_subrepos_opts \
'(--rev -r)'{-r+,--rev=}'[search the repository as it is in REV]:revision:_hg_labels' \
spectralUnsubmitted
Not Done

This is "search the repository as it is in REV" in my version (545a3e6650cd) and at default head (6f38284b)

spectral: This is "search the repository as it is in REV" in my version (545a3e6650cd) and at default…
pulkitUnsubmitted
Not Done

I changed "revision" to "REV" in flight.

pulkit: I changed "revision" to "REV" in flight.
av6AuthorUnsubmitted
Not Done

What is REV? It's a metavariable used in hg help output. It makes sense if you look at the help output while typing up hg files, but zsh's completion is supposed to help users to not constantly look at help/info/man, and here and throughout the completion file the metavariable is "revision".

Actually, looks like even hg help output most of the time spells out "revision" or "changeset" instead of using metavariables.

av6: What is REV? It's a metavariable used in hg help output. It makes sense if you look at the help…
'(--print0 -0)'{-0,--print0}'[end filenames with NUL, for use with xargs]' \
'*:file:_hg_files'
}
_hg_cmd_forget() { _hg_cmd_forget() {
_arguments -s -S : $_hg_global_opts $_hg_pat_opts $_hg_dryrun_opts \ _arguments -s -S : $_hg_global_opts $_hg_pat_opts $_hg_dryrun_opts \
'(--interactive -i)'{-i,--interactive}'[use interactive mode]' \ '(--interactive -i)'{-i,--interactive}'[use interactive mode]' \
'*:file:_hg_files' '*:file:_hg_files'
} }
_hg_cmd_graft() { _hg_cmd_graft() {
_arguments -s -S : $_hg_global_opts $_hg_dryrun_opts \ _arguments -s -S : $_hg_global_opts $_hg_dryrun_opts \