This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4376

pager: do not enable when TERM=dumb
ClosedPublic

Authored by valentin.gatienbaron on Aug 26 2018, 3:02 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG6f38284b23f4: pager: do not enable when TERM=dumb
Summary

Before this, running hg in emacs' M-x shell started less, which
would complain about the terminal not being fully functional.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Closed by commit rHG6f38284b23f4: pager: do not enable when TERM=dumb (authored by valentin.gatienbaron). · Explain WhyAug 28 2018, 2:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/ui.py (1 line)

Diff 10574

mercurial/ui.py

return return
if not command.startswith('internal-always-') and ( if not command.startswith('internal-always-') and (
# explicit --pager=on (= 'internal-always-' prefix) should # explicit --pager=on (= 'internal-always-' prefix) should
# take precedence over disabling factors below # take precedence over disabling factors below
command in self.configlist('pager', 'ignore') command in self.configlist('pager', 'ignore')
or not self.configbool('ui', 'paginate') or not self.configbool('ui', 'paginate')
or not self.configbool('pager', 'attend-' + command, True) or not self.configbool('pager', 'attend-' + command, True)
or encoding.environ.get('TERM') == 'dumb'
# TODO: if we want to allow HGPLAINEXCEPT=pager, # TODO: if we want to allow HGPLAINEXCEPT=pager,
# formatted() will need some adjustment. # formatted() will need some adjustment.
or not self.formatted() or not self.formatted()
or self.plain() or self.plain()
or self._buffers or self._buffers
# TODO: expose debugger-enabled on the UI object # TODO: expose debugger-enabled on the UI object
or '--debugger' in pycompat.sysargv): or '--debugger' in pycompat.sysargv):
# We only want to paginate if the ui appears to be # We only want to paginate if the ui appears to be