( )⚙ D4382 tests: add test to show widening is broken without ellipsis

This is an archive of the discontinued Mercurial Phabricator instance.

tests: add test to show widening is broken without ellipsis
ClosedPublic

Authored by pulkit on Aug 27 2018, 8:09 AM.

Details

Summary

This patch adds a test to show that widening a narrow clone is broken if
ellipsis is disabled.

I don't think I can add cases to existing test-narrow-widen.t and check-in a
failing version of that. So I created a copy. Once the test is fixed, we can
merge this new test file back into the original one using testcases.

Also, this is just testing treemanifest case because having two cases and both
or are failing with different outputs is a bit hard to manage.

This is important because upcoming patches will try to fix the broken part.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Aug 27 2018, 8:09 AM
martinvonz added inline comments.
tests/test-narrow-widen-non-ellipsis.t
2

nit: could you call it test-narrow-widen-no-ellipsis.t to match test-narrow-clone-no-ellipsis.t?

107

Wow, we don't even update the narrowspec? This is worse than I expected.

This revision was automatically updated to reflect the committed changes.