This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4615

wireprotov2: declare command arguments richly
ClosedPublic

Authored by indygreg on Sep 17 2018, 5:23 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG0b61d21f05cc: wireprotov2: declare command arguments richly
Summary

Previously, we declared command arguments with an example of
their value. After this commit, we declare command arguments
as a dict of metadata. This allows us to define the value
type, whether the argument is required, and provide default
values. This in turn allows us to have nice things, such as
less boilerplate code in individual commands for validating
input and assigning default values. It should also make command
behavior more consistent as a result.

Test output changed slightly because I realized that the "fields"
argument wasn't being consistently defined as a set. Oops!

Other test output changed because of slight differences in code
performing type validation.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Sep 17 2018, 5:23 PM
durin42 added a subscriber: durin42.Sep 18 2018, 5:32 PM
durin42 added inline comments.
mercurial/wireprotov2server.py
543–546

Shouldn't there be a default XOR required == true? That is, could we get away with default=None and then deriving requiredness from default-availability?

indygreg added inline comments.Sep 18 2018, 5:50 PM
mercurial/wireprotov2server.py
543–546

We could do that, sure. Would it be OK if I made that change in D4617 instead?

indygreg updated this revision to Diff 11243.Sep 20 2018, 5:14 PM
durin42 added inline comments.Sep 24 2018, 9:24 AM
mercurial/wireprotov2server.py
547

D4617 no longer exists, so I'm taking this change as-is, but expect a follow-up (at least conversation) about the default-vs-required business.

Closed by commit rHG0b61d21f05cc: wireprotov2: declare command arguments richly (authored by indygreg). · Explain WhySep 24 2018, 10:24 AM
This revision was automatically updated to reflect the committed changes.
indygreg added inline comments.Sep 24 2018, 12:17 PM
mercurial/wireprotov2server.py
601–604

Does this added check not address your review feedback, @durin42?

durin42 added a subscriber: indygreg.Sep 24 2018, 1:36 PM

indygreg added inline comments.
INLINE COMMENTS

wireprotov2server.py:602-605
+ if 'default' in meta and meta.get('required'):
+ raise error.ProgrammingError('%s argument for command %s is marked '
+ 'as required but has a default value' %
+ (arg, name))

Does this added check not address your review feedback, @durin42?

No, actually - I was proposing *removing* required entirely, and *only* keying off the existence of a default. What you reduces us to only two valid states: required-with-no-default and not-required-with-default. I think we could make the specification of a default the thing that makes the argument optional. WDYT?

indygreg added a comment.Sep 24 2018, 1:52 PM
In D4615#71677, @durin42 wrote:

No, actually - I was proposing *removing* required entirely, and *only* keying off the existence of a default. What you reduces us to only two valid states: required-with-no-default and not-required-with-default. I think we could make the specification of a default the thing that makes the argument optional. WDYT?

As far as the internal code API, I think removing required is acceptable. I'll code up a patch to do that.

Revision Contents
Changeset List

Diff 11114

mercurial/wireprotov2server.py

res.headers[b'Content-Type'] = FRAMINGTYPE res.headers[b'Content-Type'] = FRAMINGTYPE
try: try:
objs = dispatch(repo, proto, command['command']) objs = dispatch(repo, proto, command['command'])
action, meta = reactor.oncommandresponsereadyobjects( action, meta = reactor.oncommandresponsereadyobjects(
outstream, command['requestid'], objs) outstream, command['requestid'], objs)
except error.WireprotoCommandError as e:
action, meta = reactor.oncommanderror(
outstream, command['requestid'], e.message, e.messageargs)
except Exception as e: except Exception as e:
action, meta = reactor.onservererror( action, meta = reactor.onservererror(
outstream, command['requestid'], outstream, command['requestid'],
_('exception when invoking command: %s') % e) _('exception when invoking command: %s') % e)
if action == 'sendframes': if action == 'sendframes':
res.setbodygen(meta['framegen']) res.setbodygen(meta['framegen'])
return True return True
self._ui = ui self._ui = ui
self._args = args self._args = args
@property @property
def name(self): def name(self):
return HTTP_WIREPROTO_V2 return HTTP_WIREPROTO_V2
def getargs(self, args): def getargs(self, args):
# First look for args that were passed but aren't registered on this
# command.
extra = set(self._args) - set(args)
if extra:
raise error.WireprotoCommandError(
'unsupported argument to command: %s' %
', '.join(sorted(extra)))
# And look for required arguments that are missing.
missing = {a for a in args if args[a].get('required')} - set(self._args)
if missing:
raise error.WireprotoCommandError(
'missing required arguments: %s' % ', '.join(sorted(missing)))
# Now derive the arguments to pass to the command, taking into
# account the arguments specified by the client.
data = {} data = {}
for k, typ in args.items(): for k, meta in sorted(args.items()):
if k == '*': # This argument wasn't passed by the client.
raise NotImplementedError('do not support * args') if k not in self._args:
elif k in self._args: data[k] = meta.get('default', lambda: None)()
# TODO consider validating value types. continue
data[k] = self._args[k]
v = self._args[k]
# Sets may be expressed as lists. Silently normalize.
if meta['type'] == 'set' and isinstance(v, list):
v = set(v)
# TODO consider more/stronger type validation.
data[k] = v
return data return data
def getprotocaps(self): def getprotocaps(self):
# Protocol capabilities are currently not implemented for HTTP V2. # Protocol capabilities are currently not implemented for HTTP V2.
return set() return set()
def getpayload(self): def getpayload(self):
'commands': {}, 'commands': {},
'compression': compression, 'compression': compression,
'framingmediatypes': [FRAMINGTYPE], 'framingmediatypes': [FRAMINGTYPE],
} }
# TODO expose available changesetdata fields. # TODO expose available changesetdata fields.
for command, entry in COMMANDS.items(): for command, entry in COMMANDS.items():
args = {arg: meta['example'] for arg, meta in entry.args.items()}
caps['commands'][command] = { caps['commands'][command] = {
'args': entry.args, 'args': args,
'permissions': [entry.permission], 'permissions': [entry.permission],
} }
if streamclone.allowservergeneration(repo): if streamclone.allowservergeneration(repo):
caps['rawrepoformats'] = sorted(repo.requirements & caps['rawrepoformats'] = sorted(repo.requirements &
repo.supportedformats) repo.supportedformats)
return proto.addcapabilities(repo, caps) return proto.addcapabilities(repo, caps)
return revs, requests return revs, requests
def wireprotocommand(name, args=None, permission='push'): def wireprotocommand(name, args=None, permission='push'):
"""Decorator to declare a wire protocol command. """Decorator to declare a wire protocol command.
``name`` is the name of the wire protocol command being provided. ``name`` is the name of the wire protocol command being provided.
``args`` is a dict of argument names to example values. ``args`` is a dict defining arguments accepted by the command. Keys are
the argument name. Values are dicts with the following keys:
``type``
The argument data type. Must be one of the following string
literals: ``bytes``, ``int``, ``list``, ``dict``, ``set``,
or ``bool``.
``default``
A callable returning the default value for this argument.
``required``
durin42Unsubmitted
Not Done

Shouldn't there be a default XOR required == true? That is, could we get away with default=None and then deriving requiredness from default-availability?

durin42: Shouldn't there be a default XOR required == true? That is, could we get away with…
indygregAuthorUnsubmitted
Not Done

We could do that, sure. Would it be OK if I made that change in D4617 instead?

indygreg: We could do that, sure. Would it be OK if I made that change in D4617 instead?
Bool indicating whether the argument is required.
durin42Unsubmitted
Not Done

D4617 no longer exists, so I'm taking this change as-is, but expect a follow-up (at least conversation) about the default-vs-required business.

durin42: D4617 no longer exists, so I'm taking this change as-is, but expect a follow-up (at least…
``example``
An example value for this argument.
``permission`` defines the permission type needed to run this command. ``permission`` defines the permission type needed to run this command.
Can be ``push`` or ``pull``. These roughly map to read-write and read-only, Can be ``push`` or ``pull``. These roughly map to read-write and read-only,
respectively. Default is to assume command requires ``push`` permissions respectively. Default is to assume command requires ``push`` permissions
because otherwise commands not declaring their permissions could modify because otherwise commands not declaring their permissions could modify
a repository that is supposed to be read-only. a repository that is supposed to be read-only.
Wire protocol commands are generators of objects to be serialized and Wire protocol commands are generators of objects to be serialized and
if args is None: if args is None:
args = {} args = {}
if not isinstance(args, dict): if not isinstance(args, dict):
raise error.ProgrammingError('arguments for version 2 commands ' raise error.ProgrammingError('arguments for version 2 commands '
'must be declared as dicts') 'must be declared as dicts')
for arg, meta in args.items():
if arg == '*':
raise error.ProgrammingError('* argument name not allowed on '
'version 2 commands')
if not isinstance(meta, dict):
raise error.ProgrammingError('arguments for version 2 commands '
'must declare metadata as a dict')
if 'type' not in meta:
raise error.ProgrammingError('%s argument for command %s does not '
'declare type field' % (arg, name))
if meta['type'] not in ('bytes', 'int', 'list', 'dict', 'set', 'bool'):
raise error.ProgrammingError('%s argument for command %s has '
'illegal type: %s' % (arg, name,
meta['type']))
if 'example' not in meta:
raise error.ProgrammingError('%s argument for command %s does not '
'declare example field' % (arg, name))
def register(func): def register(func):
if name in COMMANDS: if name in COMMANDS:
raise error.ProgrammingError('%s command already registered ' raise error.ProgrammingError('%s command already registered '
'for version 2' % name) 'for version 2' % name)
indygregAuthorUnsubmitted
Not Done

Does this added check not address your review feedback, @durin42?

indygreg: Does this added check not address your review feedback, @durin42?
COMMANDS[name] = wireprototypes.commandentry( COMMANDS[name] = wireprototypes.commandentry(
func, args=args, transports=transports, permission=permission) func, args=args, transports=transports, permission=permission)
return func return func
return register return register
@wireprotocommand('branchmap', permission='pull') @wireprotocommand('branchmap', permission='pull')
def branchmapv2(repo, proto): def branchmapv2(repo, proto):
yield {encoding.fromlocal(k): v yield {encoding.fromlocal(k): v
for k, v in repo.branchmap().iteritems()} for k, v in repo.branchmap().iteritems()}
@wireprotocommand('capabilities', permission='pull') @wireprotocommand('capabilities', permission='pull')
def capabilitiesv2(repo, proto): def capabilitiesv2(repo, proto):
yield _capabilitiesv2(repo, proto) yield _capabilitiesv2(repo, proto)
@wireprotocommand('changesetdata', @wireprotocommand(
'changesetdata',
args={ args={
'noderange': [[b'0123456...'], [b'abcdef...']], 'noderange': {
'nodes': [b'0123456...'], 'type': 'list',
'fields': {b'parents', b'revision'}, 'example': [[b'0123456...'], [b'abcdef...']],
},
'nodes': {
'type': 'list',
'example': [b'0123456...'],
},
'fields': {
'type': 'set',
'default': set,
'example': {b'parents', b'revision'},
},
}, },
permission='pull') permission='pull')
def changesetdata(repo, proto, noderange=None, nodes=None, fields=None): def changesetdata(repo, proto, noderange, nodes, fields):
fields = fields or set()
# TODO look for unknown fields and abort when they can't be serviced. # TODO look for unknown fields and abort when they can't be serviced.
if noderange is None and nodes is None: if noderange is None and nodes is None:
raise error.WireprotoCommandError( raise error.WireprotoCommandError(
'noderange or nodes must be defined') 'noderange or nodes must be defined')
if noderange is not None: if noderange is not None:
if len(noderange) != 2: if len(noderange) != 2:
# "empty" files and return an error. # "empty" files and return an error.
fl = repo.file(path) fl = repo.file(path)
if not len(fl): if not len(fl):
raise FileAccessError(path, 'unknown file: %s', (path,)) raise FileAccessError(path, 'unknown file: %s', (path,))
return fl return fl
@wireprotocommand('filedata', @wireprotocommand(
'filedata',
args={ args={
'haveparents': True, 'haveparents': {
'nodes': [b'0123456...'], 'type': 'bool',
'fields': [b'parents', b'revision'], 'default': lambda: False,
'path': b'foo.txt', 'example': True,
},
'nodes': {
'type': 'list',
'required': True,
'example': [b'0123456...'],
},
'fields': {
'type': 'set',
'default': set,
'example': {b'parents', b'revision'},
},
'path': {
'type': 'bytes',
'required': True,
'example': b'foo.txt',
}
}, },
permission='pull') permission='pull')
def filedata(repo, proto, haveparents=False, nodes=None, fields=None, def filedata(repo, proto, haveparents, nodes, fields, path):
path=None):
fields = fields or set()
if nodes is None:
raise error.WireprotoCommandError('nodes argument must be defined')
if path is None:
raise error.WireprotoCommandError('path argument must be defined')
try: try:
# Extensions may wish to access the protocol handler. # Extensions may wish to access the protocol handler.
store = getfilestore(repo, proto, path) store = getfilestore(repo, proto, path)
except FileAccessError as e: except FileAccessError as e:
raise error.WireprotoCommandError(e.msg, e.args) raise error.WireprotoCommandError(e.msg, e.args)
# Validate requested nodes. # Validate requested nodes.
for node in nodes: for node in nodes:
if deltas is not None: if deltas is not None:
try: try:
next(deltas) next(deltas)
raise error.ProgrammingError('should not have more deltas') raise error.ProgrammingError('should not have more deltas')
except GeneratorExit: except GeneratorExit:
pass pass
@wireprotocommand('heads', @wireprotocommand(
'heads',
args={ args={
'publiconly': False, 'publiconly': {
'type': 'bool',
'default': lambda: False,
'example': False,
},
}, },
permission='pull') permission='pull')
def headsv2(repo, proto, publiconly=False): def headsv2(repo, proto, publiconly):
if publiconly: if publiconly:
repo = repo.filtered('immutable') repo = repo.filtered('immutable')
yield repo.heads() yield repo.heads()
@wireprotocommand('known', @wireprotocommand(
'known',
args={ args={
'nodes': [b'deadbeef'], 'nodes': {
'type': 'list',
'default': list,
'example': [b'deadbeef'],
},
}, },
permission='pull') permission='pull')
def knownv2(repo, proto, nodes=None): def knownv2(repo, proto, nodes):
nodes = nodes or []
result = b''.join(b'1' if n else b'0' for n in repo.known(nodes)) result = b''.join(b'1' if n else b'0' for n in repo.known(nodes))
yield result yield result
@wireprotocommand('listkeys', @wireprotocommand(
'listkeys',
args={ args={
'namespace': b'ns', 'namespace': {
'type': 'bytes',
'required': True,
'example': b'ns',
},
}, },
permission='pull') permission='pull')
def listkeysv2(repo, proto, namespace=None): def listkeysv2(repo, proto, namespace):
keys = repo.listkeys(encoding.tolocal(namespace)) keys = repo.listkeys(encoding.tolocal(namespace))
keys = {encoding.fromlocal(k): encoding.fromlocal(v) keys = {encoding.fromlocal(k): encoding.fromlocal(v)
for k, v in keys.iteritems()} for k, v in keys.iteritems()}
yield keys yield keys
@wireprotocommand('lookup', @wireprotocommand(
'lookup',
args={ args={
'key': b'foo', 'key': {
'type': 'bytes',
'required': True,
'example': b'foo',
},
}, },
permission='pull') permission='pull')
def lookupv2(repo, proto, key): def lookupv2(repo, proto, key):
key = encoding.tolocal(key) key = encoding.tolocal(key)
# TODO handle exception. # TODO handle exception.
node = repo.lookup(key) node = repo.lookup(key)
yield node yield node
@wireprotocommand('manifestdata', @wireprotocommand(
'manifestdata',
args={ args={
'nodes': [b'0123456...'], 'nodes': {
'haveparents': True, 'type': 'list',
'fields': [b'parents', b'revision'], 'required': True,
'tree': b'', 'example': [b'0123456...'],
},
'haveparents': {
'type': 'bool',
'default': lambda: False,
'example': True,
},
'fields': {
'type': 'set',
'default': set,
'example': {b'parents', b'revision'},
},
'tree': {
'type': 'bytes',
'required': True,
'example': b'',
},
}, },
permission='pull') permission='pull')
def manifestdata(repo, proto, haveparents=False, nodes=None, fields=None, def manifestdata(repo, proto, haveparents, nodes, fields, tree):
tree=None):
fields = fields or set()
if nodes is None:
raise error.WireprotoCommandError(
'nodes argument must be defined')
if tree is None:
raise error.WireprotoCommandError(
'tree argument must be defined')
store = repo.manifestlog.getstorage(tree) store = repo.manifestlog.getstorage(tree)
# Validate the node is known and abort on unknown revisions. # Validate the node is known and abort on unknown revisions.
for node in nodes: for node in nodes:
try: try:
store.rev(node) store.rev(node)
except error.LookupError: except error.LookupError:
raise error.WireprotoCommandError( raise error.WireprotoCommandError(
if deltas is not None: if deltas is not None:
try: try:
next(deltas) next(deltas)
raise error.ProgrammingError('should not have more deltas') raise error.ProgrammingError('should not have more deltas')
except GeneratorExit: except GeneratorExit:
pass pass
@wireprotocommand('pushkey', @wireprotocommand(
'pushkey',
args={ args={
'namespace': b'ns', 'namespace': {
'key': b'key', 'type': 'bytes',
'old': b'old', 'required': True,
'new': b'new', 'example': b'ns',
},
'key': {
'type': 'bytes',
'required': True,
'example': b'key',
},
'old': {
'type': 'bytes',
'required': True,
'example': b'old',
},
'new': {
'type': 'bytes',
'required': True,
'example': 'new',
},
}, },
permission='push') permission='push')
def pushkeyv2(repo, proto, namespace, key, old, new): def pushkeyv2(repo, proto, namespace, key, old, new):
# TODO handle ui output redirection # TODO handle ui output redirection
yield repo.pushkey(encoding.tolocal(namespace), yield repo.pushkey(encoding.tolocal(namespace),
encoding.tolocal(key), encoding.tolocal(key),
encoding.tolocal(old), encoding.tolocal(old),
encoding.tolocal(new)) encoding.tolocal(new))

tests/test-http-protocol.t

s> \r\n s> \r\n
s> makefile('rb', None) s> makefile('rb', None)
s> HTTP/1.1 200 OK\r\n s> HTTP/1.1 200 OK\r\n
s> Server: testing stub value\r\n s> Server: testing stub value\r\n
s> Date: $HTTP_DATE$\r\n s> Date: $HTTP_DATE$\r\n
s> Content-Type: application/mercurial-cbor\r\n s> Content-Type: application/mercurial-cbor\r\n
s> Content-Length: *\r\n (glob) s> Content-Length: *\r\n (glob)
s> \r\n s> \r\n
s> \xa3GapibaseDapi/Dapis\xa1Pexp-http-v2-0001\xa4Hcommands\xaaIbranchmap\xa2Dargs\xa0Kpermissions\x81DpullLcapabilities\xa2Dargs\xa0Kpermissions\x81DpullMchangesetdata\xa2Dargs\xa3Ffields\xd9\x01\x02\x82GparentsHrevisionInoderange\x82\x81J0123456...\x81Iabcdef...Enodes\x81J0123456...Kpermissions\x81DpullHfiledata\xa2Dargs\xa4Ffields\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...DpathGfoo.txtKpermissions\x81DpullEheads\xa2Dargs\xa1Jpubliconly\xf4Kpermissions\x81DpullEknown\xa2Dargs\xa1Enodes\x81HdeadbeefKpermissions\x81DpullHlistkeys\xa2Dargs\xa1InamespaceBnsKpermissions\x81DpullFlookup\xa2Dargs\xa1CkeyCfooKpermissions\x81DpullLmanifestdata\xa2Dargs\xa4Ffields\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...Dtree@Kpermissions\x81DpullGpushkey\xa2Dargs\xa4CkeyCkeyInamespaceBnsCnewCnewColdColdKpermissions\x81DpushKcompression\x81\xa1DnameDzlibQframingmediatypes\x81X&application/mercurial-exp-framing-0005Nrawrepoformats\x82LgeneraldeltaHrevlogv1Nv1capabilitiesY\x01\xc5batch branchmap $USUAL_BUNDLE2_CAPS_SERVER$ changegroupsubset compression=$BUNDLE2_COMPRESSIONS$ getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash s> \xa3GapibaseDapi/Dapis\xa1Pexp-http-v2-0001\xa4Hcommands\xaaIbranchmap\xa2Dargs\xa0Kpermissions\x81DpullLcapabilities\xa2Dargs\xa0Kpermissions\x81DpullMchangesetdata\xa2Dargs\xa3Ffields\xd9\x01\x02\x82GparentsHrevisionInoderange\x82\x81J0123456...\x81Iabcdef...Enodes\x81J0123456...Kpermissions\x81DpullHfiledata\xa2Dargs\xa4Ffields\xd9\x01\x02\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...DpathGfoo.txtKpermissions\x81DpullEheads\xa2Dargs\xa1Jpubliconly\xf4Kpermissions\x81DpullEknown\xa2Dargs\xa1Enodes\x81HdeadbeefKpermissions\x81DpullHlistkeys\xa2Dargs\xa1InamespaceBnsKpermissions\x81DpullFlookup\xa2Dargs\xa1CkeyCfooKpermissions\x81DpullLmanifestdata\xa2Dargs\xa4Ffields\xd9\x01\x02\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...Dtree@Kpermissions\x81DpullGpushkey\xa2Dargs\xa4CkeyCkeyInamespaceBnsCnewCnewColdColdKpermissions\x81DpushKcompression\x81\xa1DnameDzlibQframingmediatypes\x81X&application/mercurial-exp-framing-0005Nrawrepoformats\x82LgeneraldeltaHrevlogv1Nv1capabilitiesY\x01\xc5batch branchmap $USUAL_BUNDLE2_CAPS_SERVER$ changegroupsubset compression=$BUNDLE2_COMPRESSIONS$ getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash
sending heads command sending heads command
s> POST /api/exp-http-v2-0001/ro/heads HTTP/1.1\r\n s> POST /api/exp-http-v2-0001/ro/heads HTTP/1.1\r\n
s> Accept-Encoding: identity\r\n s> Accept-Encoding: identity\r\n
s> accept: application/mercurial-exp-framing-0005\r\n s> accept: application/mercurial-exp-framing-0005\r\n
s> content-type: application/mercurial-exp-framing-0005\r\n s> content-type: application/mercurial-exp-framing-0005\r\n
s> content-length: 20\r\n s> content-length: 20\r\n
s> host: $LOCALIP:$HGPORT\r\n (glob) s> host: $LOCALIP:$HGPORT\r\n (glob)
s> user-agent: Mercurial debugwireproto\r\n s> user-agent: Mercurial debugwireproto\r\n

tests/test-wireproto-command-capabilities.t

s> \r\n s> \r\n
s> makefile('rb', None) s> makefile('rb', None)
s> HTTP/1.1 200 OK\r\n s> HTTP/1.1 200 OK\r\n
s> Server: testing stub value\r\n s> Server: testing stub value\r\n
s> Date: $HTTP_DATE$\r\n s> Date: $HTTP_DATE$\r\n
s> Content-Type: application/mercurial-cbor\r\n s> Content-Type: application/mercurial-cbor\r\n
s> Content-Length: *\r\n (glob) s> Content-Length: *\r\n (glob)
s> \r\n s> \r\n
s> \xa3GapibaseDapi/Dapis\xa1Pexp-http-v2-0001\xa4Hcommands\xaaIbranchmap\xa2Dargs\xa0Kpermissions\x81DpullLcapabilities\xa2Dargs\xa0Kpermissions\x81DpullMchangesetdata\xa2Dargs\xa3Ffields\xd9\x01\x02\x82GparentsHrevisionInoderange\x82\x81J0123456...\x81Iabcdef...Enodes\x81J0123456...Kpermissions\x81DpullHfiledata\xa2Dargs\xa4Ffields\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...DpathGfoo.txtKpermissions\x81DpullEheads\xa2Dargs\xa1Jpubliconly\xf4Kpermissions\x81DpullEknown\xa2Dargs\xa1Enodes\x81HdeadbeefKpermissions\x81DpullHlistkeys\xa2Dargs\xa1InamespaceBnsKpermissions\x81DpullFlookup\xa2Dargs\xa1CkeyCfooKpermissions\x81DpullLmanifestdata\xa2Dargs\xa4Ffields\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...Dtree@Kpermissions\x81DpullGpushkey\xa2Dargs\xa4CkeyCkeyInamespaceBnsCnewCnewColdColdKpermissions\x81DpushKcompression\x81\xa1DnameDzlibQframingmediatypes\x81X&application/mercurial-exp-framing-0005Nrawrepoformats\x82LgeneraldeltaHrevlogv1Nv1capabilitiesY\x01\xc5batch branchmap $USUAL_BUNDLE2_CAPS_SERVER$ changegroupsubset compression=$BUNDLE2_COMPRESSIONS$ getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash s> \xa3GapibaseDapi/Dapis\xa1Pexp-http-v2-0001\xa4Hcommands\xaaIbranchmap\xa2Dargs\xa0Kpermissions\x81DpullLcapabilities\xa2Dargs\xa0Kpermissions\x81DpullMchangesetdata\xa2Dargs\xa3Ffields\xd9\x01\x02\x82GparentsHrevisionInoderange\x82\x81J0123456...\x81Iabcdef...Enodes\x81J0123456...Kpermissions\x81DpullHfiledata\xa2Dargs\xa4Ffields\xd9\x01\x02\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...DpathGfoo.txtKpermissions\x81DpullEheads\xa2Dargs\xa1Jpubliconly\xf4Kpermissions\x81DpullEknown\xa2Dargs\xa1Enodes\x81HdeadbeefKpermissions\x81DpullHlistkeys\xa2Dargs\xa1InamespaceBnsKpermissions\x81DpullFlookup\xa2Dargs\xa1CkeyCfooKpermissions\x81DpullLmanifestdata\xa2Dargs\xa4Ffields\xd9\x01\x02\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...Dtree@Kpermissions\x81DpullGpushkey\xa2Dargs\xa4CkeyCkeyInamespaceBnsCnewCnewColdColdKpermissions\x81DpushKcompression\x81\xa1DnameDzlibQframingmediatypes\x81X&application/mercurial-exp-framing-0005Nrawrepoformats\x82LgeneraldeltaHrevlogv1Nv1capabilitiesY\x01\xc5batch branchmap $USUAL_BUNDLE2_CAPS_SERVER$ changegroupsubset compression=$BUNDLE2_COMPRESSIONS$ getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash
cbor> { cbor> {
b'apibase': b'api/', b'apibase': b'api/',
b'apis': { b'apis': {
b'exp-http-v2-0001': { b'exp-http-v2-0001': {
b'commands': { b'commands': {
b'branchmap': { b'branchmap': {
b'args': {}, b'args': {},
b'permissions': [ b'permissions': [
] ]
}, },
b'permissions': [ b'permissions': [
b'pull' b'pull'
] ]
}, },
b'filedata': { b'filedata': {
b'args': { b'args': {
b'fields': [ b'fields': set([
b'parents', b'parents',
b'revision' b'revision'
], ]),
b'haveparents': True, b'haveparents': True,
b'nodes': [ b'nodes': [
b'0123456...' b'0123456...'
], ],
b'path': b'foo.txt' b'path': b'foo.txt'
}, },
b'permissions': [ b'permissions': [
b'pull' b'pull'
b'key': b'foo' b'key': b'foo'
}, },
b'permissions': [ b'permissions': [
b'pull' b'pull'
] ]
}, },
b'manifestdata': { b'manifestdata': {
b'args': { b'args': {
b'fields': [ b'fields': set([
b'parents', b'parents',
b'revision' b'revision'
], ]),
b'haveparents': True, b'haveparents': True,
b'nodes': [ b'nodes': [
b'0123456...' b'0123456...'
], ],
b'tree': b'' b'tree': b''
}, },
b'permissions': [ b'permissions': [
b'pull' b'pull'
s> \r\n s> \r\n
s> makefile('rb', None) s> makefile('rb', None)
s> HTTP/1.1 200 OK\r\n s> HTTP/1.1 200 OK\r\n
s> Server: testing stub value\r\n s> Server: testing stub value\r\n
s> Date: $HTTP_DATE$\r\n s> Date: $HTTP_DATE$\r\n
s> Content-Type: application/mercurial-cbor\r\n s> Content-Type: application/mercurial-cbor\r\n
s> Content-Length: *\r\n (glob) s> Content-Length: *\r\n (glob)
s> \r\n s> \r\n
s> \xa3GapibaseDapi/Dapis\xa1Pexp-http-v2-0001\xa4Hcommands\xaaIbranchmap\xa2Dargs\xa0Kpermissions\x81DpullLcapabilities\xa2Dargs\xa0Kpermissions\x81DpullMchangesetdata\xa2Dargs\xa3Ffields\xd9\x01\x02\x82GparentsHrevisionInoderange\x82\x81J0123456...\x81Iabcdef...Enodes\x81J0123456...Kpermissions\x81DpullHfiledata\xa2Dargs\xa4Ffields\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...DpathGfoo.txtKpermissions\x81DpullEheads\xa2Dargs\xa1Jpubliconly\xf4Kpermissions\x81DpullEknown\xa2Dargs\xa1Enodes\x81HdeadbeefKpermissions\x81DpullHlistkeys\xa2Dargs\xa1InamespaceBnsKpermissions\x81DpullFlookup\xa2Dargs\xa1CkeyCfooKpermissions\x81DpullLmanifestdata\xa2Dargs\xa4Ffields\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...Dtree@Kpermissions\x81DpullGpushkey\xa2Dargs\xa4CkeyCkeyInamespaceBnsCnewCnewColdColdKpermissions\x81DpushKcompression\x81\xa1DnameDzlibQframingmediatypes\x81X&application/mercurial-exp-framing-0005Nrawrepoformats\x82LgeneraldeltaHrevlogv1Nv1capabilitiesY\x01\xc5batch branchmap $USUAL_BUNDLE2_CAPS_SERVER$ changegroupsubset compression=$BUNDLE2_COMPRESSIONS$ getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash s> \xa3GapibaseDapi/Dapis\xa1Pexp-http-v2-0001\xa4Hcommands\xaaIbranchmap\xa2Dargs\xa0Kpermissions\x81DpullLcapabilities\xa2Dargs\xa0Kpermissions\x81DpullMchangesetdata\xa2Dargs\xa3Ffields\xd9\x01\x02\x82GparentsHrevisionInoderange\x82\x81J0123456...\x81Iabcdef...Enodes\x81J0123456...Kpermissions\x81DpullHfiledata\xa2Dargs\xa4Ffields\xd9\x01\x02\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...DpathGfoo.txtKpermissions\x81DpullEheads\xa2Dargs\xa1Jpubliconly\xf4Kpermissions\x81DpullEknown\xa2Dargs\xa1Enodes\x81HdeadbeefKpermissions\x81DpullHlistkeys\xa2Dargs\xa1InamespaceBnsKpermissions\x81DpullFlookup\xa2Dargs\xa1CkeyCfooKpermissions\x81DpullLmanifestdata\xa2Dargs\xa4Ffields\xd9\x01\x02\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...Dtree@Kpermissions\x81DpullGpushkey\xa2Dargs\xa4CkeyCkeyInamespaceBnsCnewCnewColdColdKpermissions\x81DpushKcompression\x81\xa1DnameDzlibQframingmediatypes\x81X&application/mercurial-exp-framing-0005Nrawrepoformats\x82LgeneraldeltaHrevlogv1Nv1capabilitiesY\x01\xc5batch branchmap $USUAL_BUNDLE2_CAPS_SERVER$ changegroupsubset compression=$BUNDLE2_COMPRESSIONS$ getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash
sending capabilities command sending capabilities command
s> POST /api/exp-http-v2-0001/ro/capabilities HTTP/1.1\r\n s> POST /api/exp-http-v2-0001/ro/capabilities HTTP/1.1\r\n
s> Accept-Encoding: identity\r\n s> Accept-Encoding: identity\r\n
s> accept: application/mercurial-exp-framing-0005\r\n s> accept: application/mercurial-exp-framing-0005\r\n
s> content-type: application/mercurial-exp-framing-0005\r\n s> content-type: application/mercurial-exp-framing-0005\r\n
s> content-length: 27\r\n s> content-length: 27\r\n
s> host: $LOCALIP:$HGPORT\r\n (glob) s> host: $LOCALIP:$HGPORT\r\n (glob)
s> user-agent: Mercurial debugwireproto\r\n s> user-agent: Mercurial debugwireproto\r\n
s> \r\n s> \r\n
s> \x13\x00\x00\x01\x00\x01\x01\x11\xa1DnameLcapabilities s> \x13\x00\x00\x01\x00\x01\x01\x11\xa1DnameLcapabilities
s> makefile('rb', None) s> makefile('rb', None)
s> HTTP/1.1 200 OK\r\n s> HTTP/1.1 200 OK\r\n
s> Server: testing stub value\r\n s> Server: testing stub value\r\n
s> Date: $HTTP_DATE$\r\n s> Date: $HTTP_DATE$\r\n
s> Content-Type: application/mercurial-exp-framing-0005\r\n s> Content-Type: application/mercurial-exp-framing-0005\r\n
s> Transfer-Encoding: chunked\r\n s> Transfer-Encoding: chunked\r\n
s> \r\n s> \r\n
s> 13\r\n s> 13\r\n
s> \x0b\x00\x00\x01\x00\x02\x011 s> \x0b\x00\x00\x01\x00\x02\x011
s> \xa1FstatusBok s> \xa1FstatusBok
s> \r\n s> \r\n
received frame(size=11; request=1; stream=2; streamflags=stream-begin; type=command-response; flags=continuation) received frame(size=11; request=1; stream=2; streamflags=stream-begin; type=command-response; flags=continuation)
s> 30e\r\n s> 314\r\n
s> \x06\x03\x00\x01\x00\x02\x001 s> \x0c\x03\x00\x01\x00\x02\x001
s> \xa4Hcommands\xaaIbranchmap\xa2Dargs\xa0Kpermissions\x81DpullLcapabilities\xa2Dargs\xa0Kpermissions\x81DpullMchangesetdata\xa2Dargs\xa3Ffields\xd9\x01\x02\x82GparentsHrevisionInoderange\x82\x81J0123456...\x81Iabcdef...Enodes\x81J0123456...Kpermissions\x81DpullHfiledata\xa2Dargs\xa4Ffields\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...DpathGfoo.txtKpermissions\x81DpullEheads\xa2Dargs\xa1Jpubliconly\xf4Kpermissions\x81DpullEknown\xa2Dargs\xa1Enodes\x81HdeadbeefKpermissions\x81DpullHlistkeys\xa2Dargs\xa1InamespaceBnsKpermissions\x81DpullFlookup\xa2Dargs\xa1CkeyCfooKpermissions\x81DpullLmanifestdata\xa2Dargs\xa4Ffields\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...Dtree@Kpermissions\x81DpullGpushkey\xa2Dargs\xa4CkeyCkeyInamespaceBnsCnewCnewColdColdKpermissions\x81DpushKcompression\x81\xa1DnameDzlibQframingmediatypes\x81X&application/mercurial-exp-framing-0005Nrawrepoformats\x82LgeneraldeltaHrevlogv1 s> \xa4Hcommands\xaaIbranchmap\xa2Dargs\xa0Kpermissions\x81DpullLcapabilities\xa2Dargs\xa0Kpermissions\x81DpullMchangesetdata\xa2Dargs\xa3Ffields\xd9\x01\x02\x82GparentsHrevisionInoderange\x82\x81J0123456...\x81Iabcdef...Enodes\x81J0123456...Kpermissions\x81DpullHfiledata\xa2Dargs\xa4Ffields\xd9\x01\x02\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...DpathGfoo.txtKpermissions\x81DpullEheads\xa2Dargs\xa1Jpubliconly\xf4Kpermissions\x81DpullEknown\xa2Dargs\xa1Enodes\x81HdeadbeefKpermissions\x81DpullHlistkeys\xa2Dargs\xa1InamespaceBnsKpermissions\x81DpullFlookup\xa2Dargs\xa1CkeyCfooKpermissions\x81DpullLmanifestdata\xa2Dargs\xa4Ffields\xd9\x01\x02\x82GparentsHrevisionKhaveparents\xf5Enodes\x81J0123456...Dtree@Kpermissions\x81DpullGpushkey\xa2Dargs\xa4CkeyCkeyInamespaceBnsCnewCnewColdColdKpermissions\x81DpushKcompression\x81\xa1DnameDzlibQframingmediatypes\x81X&application/mercurial-exp-framing-0005Nrawrepoformats\x82LgeneraldeltaHrevlogv1
s> \r\n s> \r\n
received frame(size=774; request=1; stream=2; streamflags=; type=command-response; flags=continuation) received frame(size=780; request=1; stream=2; streamflags=; type=command-response; flags=continuation)
s> 8\r\n s> 8\r\n
s> \x00\x00\x00\x01\x00\x02\x002 s> \x00\x00\x00\x01\x00\x02\x002
s> \r\n s> \r\n
s> 0\r\n s> 0\r\n
s> \r\n s> \r\n
received frame(size=0; request=1; stream=2; streamflags=; type=command-response; flags=eos) received frame(size=0; request=1; stream=2; streamflags=; type=command-response; flags=eos)
response: gen[ response: gen[
{ {
] ]
}, },
b'permissions': [ b'permissions': [
b'pull' b'pull'
] ]
}, },
b'filedata': { b'filedata': {
b'args': { b'args': {
b'fields': [ b'fields': set([
b'parents', b'parents',
b'revision' b'revision'
], ]),
b'haveparents': True, b'haveparents': True,
b'nodes': [ b'nodes': [
b'0123456...' b'0123456...'
], ],
b'path': b'foo.txt' b'path': b'foo.txt'
}, },
b'permissions': [ b'permissions': [
b'pull' b'pull'
b'key': b'foo' b'key': b'foo'
}, },
b'permissions': [ b'permissions': [
b'pull' b'pull'
] ]
}, },
b'manifestdata': { b'manifestdata': {
b'args': { b'args': {
b'fields': [ b'fields': set([
b'parents', b'parents',
b'revision' b'revision'
], ]),
b'haveparents': True, b'haveparents': True,
b'nodes': [ b'nodes': [
b'0123456...' b'0123456...'
], ],
b'tree': b'' b'tree': b''
}, },
b'permissions': [ b'permissions': [
b'pull' b'pull'

tests/test-wireproto-command-filedata.t

s> \x0f\x00\x00\x01\x00\x01\x01\x11\xa1DnameHfiledata s> \x0f\x00\x00\x01\x00\x01\x01\x11\xa1DnameHfiledata
s> makefile('rb', None) s> makefile('rb', None)
s> HTTP/1.1 200 OK\r\n s> HTTP/1.1 200 OK\r\n
s> Server: testing stub value\r\n s> Server: testing stub value\r\n
s> Date: $HTTP_DATE$\r\n s> Date: $HTTP_DATE$\r\n
s> Content-Type: application/mercurial-exp-framing-0005\r\n s> Content-Type: application/mercurial-exp-framing-0005\r\n
s> Transfer-Encoding: chunked\r\n s> Transfer-Encoding: chunked\r\n
s> \r\n s> \r\n
s> 45\r\n s> 4e\r\n
s> =\x00\x00\x01\x00\x02\x012 s> F\x00\x00\x01\x00\x02\x012
s> \xa2Eerror\xa1GmessageX\x1enodes argument must be definedFstatusEerror s> \xa2Eerror\xa1GmessageX\'missing required arguments: nodes, pathFstatusEerror
s> \r\n s> \r\n
received frame(size=61; request=1; stream=2; streamflags=stream-begin; type=command-response; flags=eos) received frame(size=70; request=1; stream=2; streamflags=stream-begin; type=command-response; flags=eos)
s> 0\r\n s> 0\r\n
s> \r\n s> \r\n
abort: nodes argument must be defined! abort: missing required arguments: nodes, path!
[255] [255]
$ sendhttpv2peer << EOF $ sendhttpv2peer << EOF
> command filedata > command filedata
> nodes eval:[] > nodes eval:[]
> EOF > EOF
creating http peer for wire protocol version 2 creating http peer for wire protocol version 2
sending filedata command sending filedata command
s> POST /api/exp-http-v2-0001/ro/filedata HTTP/1.1\r\n s> POST /api/exp-http-v2-0001/ro/filedata HTTP/1.1\r\n
s> Accept-Encoding: identity\r\n s> Accept-Encoding: identity\r\n
s> accept: application/mercurial-exp-framing-0005\r\n s> accept: application/mercurial-exp-framing-0005\r\n
s> content-type: application/mercurial-exp-framing-0005\r\n s> content-type: application/mercurial-exp-framing-0005\r\n
s> content-length: 36\r\n s> content-length: 36\r\n
s> host: $LOCALIP:$HGPORT\r\n (glob) s> host: $LOCALIP:$HGPORT\r\n (glob)
s> user-agent: Mercurial debugwireproto\r\n s> user-agent: Mercurial debugwireproto\r\n
s> \r\n s> \r\n
s> \x1c\x00\x00\x01\x00\x01\x01\x11\xa2Dargs\xa1Enodes\x80DnameHfiledata s> \x1c\x00\x00\x01\x00\x01\x01\x11\xa2Dargs\xa1Enodes\x80DnameHfiledata
s> makefile('rb', None) s> makefile('rb', None)
s> HTTP/1.1 200 OK\r\n s> HTTP/1.1 200 OK\r\n
s> Server: testing stub value\r\n s> Server: testing stub value\r\n
s> Date: $HTTP_DATE$\r\n s> Date: $HTTP_DATE$\r\n
s> Content-Type: application/mercurial-exp-framing-0005\r\n s> Content-Type: application/mercurial-exp-framing-0005\r\n
s> Transfer-Encoding: chunked\r\n s> Transfer-Encoding: chunked\r\n
s> \r\n s> \r\n
s> 44\r\n s> 47\r\n
s> <\x00\x00\x01\x00\x02\x012 s> ?\x00\x00\x01\x00\x02\x012
s> \xa2Eerror\xa1GmessageX\x1dpath argument must be definedFstatusEerror s> \xa2Eerror\xa1GmessageX missing required arguments: pathFstatusEerror
s> \r\n s> \r\n
received frame(size=60; request=1; stream=2; streamflags=stream-begin; type=command-response; flags=eos) received frame(size=63; request=1; stream=2; streamflags=stream-begin; type=command-response; flags=eos)
s> 0\r\n s> 0\r\n
s> \r\n s> \r\n
abort: path argument must be defined! abort: missing required arguments: path!
[255] [255]
Unknown node is an error Unknown node is an error
$ sendhttpv2peer << EOF $ sendhttpv2peer << EOF
> command filedata > command filedata
> nodes eval:[b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa'] > nodes eval:[b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa']
> path eval:b'a' > path eval:b'a'

tests/test-wireproto-command-manifestdata.t

s> \x13\x00\x00\x01\x00\x01\x01\x11\xa1DnameLmanifestdata s> \x13\x00\x00\x01\x00\x01\x01\x11\xa1DnameLmanifestdata
s> makefile('rb', None) s> makefile('rb', None)
s> HTTP/1.1 200 OK\r\n s> HTTP/1.1 200 OK\r\n
s> Server: testing stub value\r\n s> Server: testing stub value\r\n
s> Date: $HTTP_DATE$\r\n s> Date: $HTTP_DATE$\r\n
s> Content-Type: application/mercurial-exp-framing-0005\r\n s> Content-Type: application/mercurial-exp-framing-0005\r\n
s> Transfer-Encoding: chunked\r\n s> Transfer-Encoding: chunked\r\n
s> \r\n s> \r\n
s> 45\r\n s> 4e\r\n
s> =\x00\x00\x01\x00\x02\x012 s> F\x00\x00\x01\x00\x02\x012
s> \xa2Eerror\xa1GmessageX\x1enodes argument must be definedFstatusEerror s> \xa2Eerror\xa1GmessageX\'missing required arguments: nodes, treeFstatusEerror
s> \r\n s> \r\n
received frame(size=61; request=1; stream=2; streamflags=stream-begin; type=command-response; flags=eos) received frame(size=70; request=1; stream=2; streamflags=stream-begin; type=command-response; flags=eos)
s> 0\r\n s> 0\r\n
s> \r\n s> \r\n
abort: nodes argument must be defined! abort: missing required arguments: nodes, tree!
[255] [255]
$ sendhttpv2peer << EOF $ sendhttpv2peer << EOF
> command manifestdata > command manifestdata
> nodes eval:[] > nodes eval:[]
> EOF > EOF
creating http peer for wire protocol version 2 creating http peer for wire protocol version 2
sending manifestdata command sending manifestdata command
s> POST /api/exp-http-v2-0001/ro/manifestdata HTTP/1.1\r\n s> POST /api/exp-http-v2-0001/ro/manifestdata HTTP/1.1\r\n
s> Accept-Encoding: identity\r\n s> Accept-Encoding: identity\r\n
s> accept: application/mercurial-exp-framing-0005\r\n s> accept: application/mercurial-exp-framing-0005\r\n
s> content-type: application/mercurial-exp-framing-0005\r\n s> content-type: application/mercurial-exp-framing-0005\r\n
s> content-length: 40\r\n s> content-length: 40\r\n
s> host: $LOCALIP:$HGPORT\r\n (glob) s> host: $LOCALIP:$HGPORT\r\n (glob)
s> user-agent: Mercurial debugwireproto\r\n s> user-agent: Mercurial debugwireproto\r\n
s> \r\n s> \r\n
s> \x00\x00\x01\x00\x01\x01\x11\xa2Dargs\xa1Enodes\x80DnameLmanifestdata s> \x00\x00\x01\x00\x01\x01\x11\xa2Dargs\xa1Enodes\x80DnameLmanifestdata
s> makefile('rb', None) s> makefile('rb', None)
s> HTTP/1.1 200 OK\r\n s> HTTP/1.1 200 OK\r\n
s> Server: testing stub value\r\n s> Server: testing stub value\r\n
s> Date: $HTTP_DATE$\r\n s> Date: $HTTP_DATE$\r\n
s> Content-Type: application/mercurial-exp-framing-0005\r\n s> Content-Type: application/mercurial-exp-framing-0005\r\n
s> Transfer-Encoding: chunked\r\n s> Transfer-Encoding: chunked\r\n
s> \r\n s> \r\n
s> 44\r\n s> 47\r\n
s> <\x00\x00\x01\x00\x02\x012 s> ?\x00\x00\x01\x00\x02\x012
s> \xa2Eerror\xa1GmessageX\x1dtree argument must be definedFstatusEerror s> \xa2Eerror\xa1GmessageX missing required arguments: treeFstatusEerror
s> \r\n s> \r\n
received frame(size=60; request=1; stream=2; streamflags=stream-begin; type=command-response; flags=eos) received frame(size=63; request=1; stream=2; streamflags=stream-begin; type=command-response; flags=eos)
s> 0\r\n s> 0\r\n
s> \r\n s> \r\n
abort: tree argument must be defined! abort: missing required arguments: tree!
[255] [255]
Unknown node is an error Unknown node is an error
$ sendhttpv2peer << EOF $ sendhttpv2peer << EOF
> command manifestdata > command manifestdata
> nodes eval:[b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa'] > nodes eval:[b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa']
> tree eval:b'' > tree eval:b''