This is an archive of the discontinued Mercurial Phabricator instance.

wireprotov2: advertise set of valid values for requestable fields
ClosedPublic

Authored by indygreg on Sep 17 2018, 5:24 PM.

Details

Summary

changesetdata, manifestdata, and filedata all allow the caller to
specify what data fields to request.

Data fields are extensible and may evolve over time. In order to
prevent clients from making requests for fields that are not
available, the client needs to know what fields are available.

This commit teaches the server to declare a set of "valid values"
for wire protocol command arguments. That set of values is exposed
in the command's capabilities descriptor. The changesetdata,
manifestdata, and filedata commands all declare their set of
available "fields."

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 17 2018, 5:24 PM
durin42 accepted this revision.Sep 18 2018, 5:35 PM
This revision is now accepted and ready to land.Sep 18 2018, 5:35 PM
indygreg updated this revision to Diff 11246.Sep 20 2018, 5:14 PM
This revision was automatically updated to reflect the committed changes.