This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4702

filelog: remove version attribute (API)
ClosedPublic

Authored by indygreg on Sep 24 2018, 12:12 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG68282a7b29a7: filelog: remove version attribute (API)
Summary

This was only used by verify code. The check it was used for is now
implemented as part of the verifyintegrity() implementation. The
attribute is now unused, is revlog-specific, and isn't appropriate
to be exposing on the file storage interface. So drop it.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Sep 24 2018, 12:12 PM
Closed by commit rHG68282a7b29a7: filelog: remove version attribute (API) (authored by indygreg). · Explain WhySep 26 2018, 1:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/filelog.py (2 lines)
Mmercurial/repository.py (6 lines)
Mtests/simplestorerepo.py (2 lines)

Diff 11310

mercurial/filelog.py

self._revlog = revlog.revlog(opener, self._revlog = revlog.revlog(opener,
'/'.join(('data', path + '.i')), '/'.join(('data', path + '.i')),
censorable=True) censorable=True)
# Full name of the user visible file, relative to the repository root. # Full name of the user visible file, relative to the repository root.
# Used by LFS. # Used by LFS.
self.filename = path self.filename = path
# Used by repo upgrade. # Used by repo upgrade.
self.index = self._revlog.index self.index = self._revlog.index
# Used by verify.
self.version = self._revlog.version
# Used by changegroup generation. # Used by changegroup generation.
self._generaldelta = self._revlog._generaldelta self._generaldelta = self._revlog._generaldelta
def __len__(self): def __len__(self):
return len(self._revlog) return len(self._revlog)
def __iter__(self): def __iter__(self):
return self._revlog.__iter__() return self._revlog.__iter__()

mercurial/repository.py

TODO this is highly revlog centric and should be abstracted into a TODO this is highly revlog centric and should be abstracted into a
higher-level deletion API. higher-level deletion API.
""" """
class ifilestorage(ifileindex, ifiledata, ifilemutation): class ifilestorage(ifileindex, ifiledata, ifilemutation):
"""Complete storage interface for a single tracked file.""" """Complete storage interface for a single tracked file."""
version = interfaceutil.Attribute(
"""Version number of storage.
TODO this feels revlog centric and could likely be removed.
""")
_generaldelta = interfaceutil.Attribute( _generaldelta = interfaceutil.Attribute(
"""Whether deltas can be against any parent revision. """Whether deltas can be against any parent revision.
TODO this is used by changegroup code and it could probably be TODO this is used by changegroup code and it could probably be
folded into another API. folded into another API.
""") """)
def files(): def files():

tests/simplestorerepo.py

self._indexbynode = {} self._indexbynode = {}
self._indexbyrev = {} self._indexbyrev = {}
self.index = [] self.index = []
self._refreshindex() self._refreshindex()
# This is used by changegroup code :/ # This is used by changegroup code :/
self._generaldelta = True self._generaldelta = True
self.version = 1
def _refreshindex(self): def _refreshindex(self):
self._indexbynode.clear() self._indexbynode.clear()
self._indexbyrev.clear() self._indexbyrev.clear()
self.index = [] self.index = []
for i, entry in enumerate(self._indexdata): for i, entry in enumerate(self._indexdata):
self._indexbynode[entry[b'node']] = entry self._indexbynode[entry[b'node']] = entry
self._indexbyrev[i] = entry self._indexbyrev[i] = entry