This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4727

filelog: drop _generaldelta attribute (API)
ClosedPublic

Authored by indygreg on Sep 24 2018, 1:15 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG4b816a83e17e: filelog: drop _generaldelta attribute (API)
Summary

With changegroup moving to emitrevisions(), this revlog-specific
attribute is no longer used and can be deleted. Good riddance.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Sep 24 2018, 1:15 PM
Closed by commit rHG4b816a83e17e: filelog: drop _generaldelta attribute (API) (authored by indygreg). · Explain WhySep 26 2018, 1:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/filelog.py (2 lines)
Mmercurial/repository.py (7 lines)
Mtests/simplestorerepo.py (3 lines)

Diff 11335

mercurial/filelog.py

class filelog(object): class filelog(object):
def __init__(self, opener, path): def __init__(self, opener, path):
self._revlog = revlog.revlog(opener, self._revlog = revlog.revlog(opener,
'/'.join(('data', path + '.i')), '/'.join(('data', path + '.i')),
censorable=True) censorable=True)
# Full name of the user visible file, relative to the repository root. # Full name of the user visible file, relative to the repository root.
# Used by LFS. # Used by LFS.
self._revlog.filename = path self._revlog.filename = path
# Used by changegroup generation.
self._generaldelta = self._revlog._generaldelta
def __len__(self): def __len__(self):
return len(self._revlog) return len(self._revlog)
def __iter__(self): def __iter__(self):
return self._revlog.__iter__() return self._revlog.__iter__()
def revs(self, start=0, stop=None): def revs(self, start=0, stop=None):

mercurial/repository.py

TODO this is highly revlog centric and should be abstracted into a TODO this is highly revlog centric and should be abstracted into a
higher-level deletion API. higher-level deletion API.
""" """
class ifilestorage(ifileindex, ifiledata, ifilemutation): class ifilestorage(ifileindex, ifiledata, ifilemutation):
"""Complete storage interface for a single tracked file.""" """Complete storage interface for a single tracked file."""
_generaldelta = interfaceutil.Attribute(
"""Whether deltas can be against any parent revision.
TODO this is used by changegroup code and it could probably be
folded into another API.
""")
def files(): def files():
"""Obtain paths that are backing storage for this file. """Obtain paths that are backing storage for this file.
TODO this is used heavily by verify code and there should probably TODO this is used heavily by verify code and there should probably
be a better API for that. be a better API for that.
""" """
def verifyintegrity(state): def verifyintegrity(state):

tests/simplestorerepo.py

indexdata = cbor.loads(indexdata) indexdata = cbor.loads(indexdata)
self._indexdata = indexdata or [] self._indexdata = indexdata or []
self._indexbynode = {} self._indexbynode = {}
self._indexbyrev = {} self._indexbyrev = {}
self._index = [] self._index = []
self._refreshindex() self._refreshindex()
# This is used by changegroup code :/
self._generaldelta = True
def _refreshindex(self): def _refreshindex(self):
self._indexbynode.clear() self._indexbynode.clear()
self._indexbyrev.clear() self._indexbyrev.clear()
self._index = [] self._index = []
for i, entry in enumerate(self._indexdata): for i, entry in enumerate(self._indexdata):
self._indexbynode[entry[b'node']] = entry self._indexbynode[entry[b'node']] = entry
self._indexbyrev[i] = entry self._indexbyrev[i] = entry