| hg-reviewers |
Right now there is no good way to check whether a repo is ellipses enabled or
not. This patch introduces a ellipses repo requirement which will be used in
upcoming patches.
I have purposefully not included narrow in the requirement name because now they
are looking different concepts to me.
| Lint Skipped |
| Unit Tests Skipped |
| mercurial/repository.py | ||
|---|---|---|
| 22–24 | I'm not sure I understand what this says. The first sentence sounds too obvious to mention (kind of like "when it's done, it should be working well"), but I suspect you mean something else. Do you mean that that's the criteria for dropping the "exp-" prefix (much like the comment for narrow says above)? I don't know what the second sentence says either. Isn't it already generalized to shallow and ellipses? | |
| mercurial/repository.py | ||
|---|---|---|
| 22–24 | Yeah, the intent was to say the same thing as the comment about NARROW_REQUIREMENT says but re-reading myself, looks like I messed up. I will update this. | |
Let's do this step by step and get the wireprotocol command reviewed first. Once that is done, I will resend this one.
I think this patch (and later patches that start using it, of course) would be a good idea. I suppose it won't make it into 4.8, but we don't have a freeze, so please send an updated version whenever you have time
I'm not sure I understand what this says.
The first sentence sounds too obvious to mention (kind of like "when it's done, it should be working well"), but I suspect you mean something else. Do you mean that that's the criteria for dropping the "exp-" prefix (much like the comment for narrow says above)?
I don't know what the second sentence says either. Isn't it already generalized to shallow and ellipses?