This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4846

narrow: avoid overwriting a variable
ClosedPublic

Authored by martinvonz on Oct 3 2018, 1:25 AM.

Details

Reviewers
durin42
pulkit
Group Reviewers
hg-reviewers
Commits
rHG825a636812a4: narrow: avoid overwriting a variable
Summary

I don't like to overwrite variables, especially not with a different
type (because it makes it harder to explain what the variable is for,
and, therefore, to name it well).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Oct 3 2018, 1:25 AM
pulkit accepted this revision.Oct 3 2018, 6:47 AM
Closed by commit rHG825a636812a4: narrow: avoid overwriting a variable (authored by martinvonz). · Explain WhyOct 3 2018, 6:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/narrow/narrowbundle2.py (5 lines)

Diff 11587

hgext/narrow/narrowbundle2.py

cgversion is the changegroup version to send cgversion is the changegroup version to send
ellipses is boolean value telling whether to send ellipses data or not ellipses is boolean value telling whether to send ellipses data or not
returns changegroup data of the changegroup built or return None if there returns changegroup data of the changegroup built or return None if there
are no common revs are no common revs
""" """
# XXX: This patch will start sending bundle2 after couple of patches when # XXX: This patch will start sending bundle2 after couple of patches when
# called from the wireprotocol command # called from the wireprotocol command
common = repo.revs("::%ln", common)
commonnodes = set() commonnodes = set()
cl = repo.changelog cl = repo.changelog
for c in common: for r in repo.revs("::%ln", common):
commonnodes.add(cl.node(c)) commonnodes.add(cl.node(r))
if commonnodes: if commonnodes:
# XXX: we should only send the filelogs (and treemanifest). user # XXX: we should only send the filelogs (and treemanifest). user
# already has the changelog and manifest # already has the changelog and manifest
packer = changegroup.getbundler(cgversion, repo, packer = changegroup.getbundler(cgversion, repo,
filematcher=diffmatcher, filematcher=diffmatcher,
fullnodes=commonnodes) fullnodes=commonnodes)
cgdata = packer.generate(set([nullid]), list(commonnodes), False, cgdata = packer.generate(set([nullid]), list(commonnodes), False,
'narrow_widen', changelog=False) 'narrow_widen', changelog=False)