( )⚙ D485 infinitepush: update test to reflect upstream change

This is an archive of the discontinued Mercurial Phabricator instance.

infinitepush: update test to reflect upstream change
ClosedPublic

Authored by quark on Aug 23 2017, 12:36 AM.
Tags
None
Subscribers

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rFBHGX07648c8cd7ac: infinitepush: update test to reflect upstream change
Summary

It seems debugcheckbackup could get a new kind of error with the latest
upstream code:

Traceback (most recent call last):
  File "hg/mercurial/scmutil.py", line 150, in callcatch
    return func()
  File "hg/mercurial/dispatch.py", line 292, in _runcatchfunc
    return _dispatch(req)
  File "hg/mercurial/dispatch.py", line 896, in _dispatch
    cmdpats, cmdoptions)
  File "hg/mercurial/dispatch.py", line 658, in runcommand
    ret = _runcommand(ui, options, cmd, d)
  File "hg/mercurial/dispatch.py", line 904, in _runcommand
    return cmdfunc()
  File "hg/mercurial/dispatch.py", line 893, in <lambda>
    d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
  File "hg/mercurial/util.py", line 1118, in check
    return func(*args, **kwargs)
  File "hg/mercurial/extensions.py", line 322, in closure
    return func(*(args + a), **kw)
  File "hg/mercurial/util.py", line 1118, in check
    return func(*args, **kwargs)
  File "hg/hgext/mq.py", line 3542, in mqcommand
    return orig(ui, repo, *args, **kwargs)
  File "hg/mercurial/util.py", line 1118, in check
    return func(*args, **kwargs)
  File "fb-hgext/infinitepush/backupcommands.py", line 272, in checkbackup
    if not _dobackupcheck(bkpstate, ui, repo, dest, **opts):
  File "fb-hgext/infinitepush/backupcommands.py", line 469, in _dobackupcheck
    for r in lookupresults:
  File "hg/mercurial/wireproto.py", line 137, in results
    next(batchable)
  File "hg/mercurial/wireproto.py", line 238, in lookup
    self._abort(error.RepoError(data))
  File "hg/mercurial/sshpeer.py", line 235, in _abort
    raise exception
RepoError: 0e1a088ff2825213eaa838a82a842bc186f10dd5
abort: 0e1a088ff2825213eaa838a82a842bc186f10dd5!

The error message only contains a commit hash, which is not friendly to be
printed out. Therefore make sure we have control about the error message and
update the test accordingly.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Aug 23 2017, 12:36 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 23 2017, 12:36 AM
quark updated this revision to Diff 1185.Aug 23 2017, 12:43 AM
quark updated this revision to Diff 1186.Aug 23 2017, 12:50 AM
quark added a subscriber: stash.Aug 23 2017, 12:58 AM

I'm pushing the fixes trying to unblock the build.

@stash I'm not very sure about what happens exactly here. But it looks like it's a debug command so it seems not too risky to move forward.

This revision was automatically updated to reflect the committed changes.
stash added a comment.Aug 23 2017, 4:53 AM

These failures are quite weird. I'll take a look

durham added a subscriber: durham.Sep 7 2017, 12:55 AM

The failures look like they were fixed upstream in D608.