This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4868

revlog: move loading of index data into own method
ClosedPublic

Authored by indygreg on Oct 3 2018, 2:13 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG0a4625ffd6c0: revlog: move loading of index data into own method
rHG41110c516ade: revlog: move loading of index data into own method
Summary

This will allow us to "reload" a revlog instance from a rewritten
index file, which will be used in a subsequent commit.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 3 2018, 2:13 PM
Closed by commit rHG41110c516ade: revlog: move loading of index data into own method (authored by indygreg). · Explain WhyOct 4 2018, 6:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (5 lines)

Diff 11688

mercurial/revlog.py

if self._chunkcachesize <= 0: if self._chunkcachesize <= 0:
raise error.RevlogError(_('revlog chunk cache size %r is not ' raise error.RevlogError(_('revlog chunk cache size %r is not '
'greater than 0') % self._chunkcachesize) 'greater than 0') % self._chunkcachesize)
elif self._chunkcachesize & (self._chunkcachesize - 1): elif self._chunkcachesize & (self._chunkcachesize - 1):
raise error.RevlogError(_('revlog chunk cache size %r is not a ' raise error.RevlogError(_('revlog chunk cache size %r is not a '
'power of 2') % self._chunkcachesize) 'power of 2') % self._chunkcachesize)
self._loadindex(v, mmapindexthreshold)
def _loadindex(self, v, mmapindexthreshold):
indexdata = '' indexdata = ''
self._initempty = True self._initempty = True
try: try:
with self._indexfp() as f: with self._indexfp() as f:
if (mmapindexthreshold is not None and if (mmapindexthreshold is not None and
self.opener.fstat(f).st_size >= mmapindexthreshold): self.opener.fstat(f).st_size >= mmapindexthreshold):
indexdata = util.buffer(util.mmapread(f)) indexdata = util.buffer(util.mmapread(f))
else: else:
indexdata = f.read() indexdata = f.read()
if len(indexdata) > 0: if len(indexdata) > 0:
v = versionformat_unpack(indexdata[:4])[0] v = versionformat_unpack(indexdata[:4])[0]
self._initempty = False self._initempty = False
except IOError as inst: except IOError as inst:
if inst.errno != errno.ENOENT: if inst.errno != errno.ENOENT: