This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4863

wireprotov2: always advertise raw repo requirements
ClosedPublic

Authored by indygreg on Oct 3 2018, 2:13 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG39074a35f7db: wireprotov2: always advertise raw repo requirements
rHGed556a5201e5: wireprotov2: always advertise raw repo requirements
Summary

I'm pretty sure my original thinking behind making it conditional
on stream clone support was that the behavior mirrored wire protocol
version 1.

I don't see a compelling reason for us to not advertise the server's
storage requirements. The proper way to advertise stream clone support
in wireprotov2 would be to not advertise the command(s) required to
perform stream clone or to advertise a separate capability denoting
stream clone support.

Stream clone isn't yet implemented on wireprotov2, so we can cross
this bridge later.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 3 2018, 2:13 PM
martinvonz added a subscriber: martinvonz.Oct 4 2018, 2:13 PM

I don't see a compelling reason for us to not advertise the server's storage requirements.

I don't see much harm in it either, but it also seems like most of the requirements should not matter to the client. I feel like it would be better to explicitly expose requirements that the client needs to care about.

Closed by commit rHGed556a5201e5: wireprotov2: always advertise raw repo requirements (authored by indygreg). · Explain WhyOct 4 2018, 2:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/wireprotov2server.py (6 lines)

Diff 11682

mercurial/wireprotov2server.py

nullid, nullid,
) )
from . import ( from . import (
discovery, discovery,
encoding, encoding,
error, error,
narrowspec, narrowspec,
pycompat, pycompat,
streamclone,
util, util,
wireprotoframing, wireprotoframing,
wireprototypes, wireprototypes,
) )
from .utils import ( from .utils import (
cborutil, cborutil,
interfaceutil, interfaceutil,
stringutil, stringutil,
if meta['validvalues']: if meta['validvalues']:
args[arg][b'validvalues'] = meta['validvalues'] args[arg][b'validvalues'] = meta['validvalues']
caps['commands'][command] = { caps['commands'][command] = {
'args': args, 'args': args,
'permissions': [entry.permission], 'permissions': [entry.permission],
} }
if streamclone.allowservergeneration(repo):
caps['rawrepoformats'] = sorted(repo.requirements & caps['rawrepoformats'] = sorted(repo.requirements &
repo.supportedformats) repo.supportedformats)
targets = getadvertisedredirecttargets(repo, proto) targets = getadvertisedredirecttargets(repo, proto)
if targets: if targets:
caps[b'redirect'] = { caps[b'redirect'] = {
b'targets': [], b'targets': [],
b'hashes': [b'sha256', b'sha1'], b'hashes': [b'sha256', b'sha1'],
} }