This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4853

streamclone: don't support stream clone unless repo feature present
ClosedPublic

Authored by indygreg on Oct 3 2018, 12:51 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG51f10e6d66c7: streamclone: don't support stream clone unless repo feature present
Summary

This change means custom repository types must opt in to enabling
stream clone. This seems reasonable, as stream clones are a very
low-level feature that has historically assumed the use of revlogs
and the layout of .hg/ that they entail.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 3 2018, 12:51 PM
pulkit accepted this revision.Oct 3 2018, 12:59 PM
Closed by commit rHG51f10e6d66c7: streamclone: don't support stream clone unless repo feature present (authored by indygreg). · Explain WhyOct 3 2018, 1:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/streamclone.py (4 lines)

Diff 11641

mercurial/streamclone.py

from .i18n import _ from .i18n import _
from . import ( from . import (
branchmap, branchmap,
cacheutil, cacheutil,
error, error,
phases, phases,
pycompat, pycompat,
repository,
store, store,
util, util,
) )
def canperformstreamclone(pullop, bundle2=False): def canperformstreamclone(pullop, bundle2=False):
"""Whether it is possible to perform a streaming clone as part of pull. """Whether it is possible to perform a streaming clone as part of pull.
``bundle2`` will cause the function to consider stream clone through ``bundle2`` will cause the function to consider stream clone through
if rbranchmap: if rbranchmap:
branchmap.replacecache(repo, rbranchmap) branchmap.replacecache(repo, rbranchmap)
repo.invalidate() repo.invalidate()
def allowservergeneration(repo): def allowservergeneration(repo):
"""Whether streaming clones are allowed from the server.""" """Whether streaming clones are allowed from the server."""
if repository.REPO_FEATURE_STREAM_CLONE not in repo.features:
return False
if not repo.ui.configbool('server', 'uncompressed', untrusted=True): if not repo.ui.configbool('server', 'uncompressed', untrusted=True):
return False return False
# The way stream clone works makes it impossible to hide secret changesets. # The way stream clone works makes it impossible to hide secret changesets.
# So don't allow this by default. # So don't allow this by default.
secret = phases.hassecret(repo) secret = phases.hassecret(repo)
if secret: if secret:
return repo.ui.configbool('server', 'uncompressedallowsecret') return repo.ui.configbool('server', 'uncompressedallowsecret')