Page MenuHomePhabricator

test-extension: enable demandimport explicitly
AbandonedPublic

Authored by quark on Aug 23 2017, 2:03 AM.

Details

Reviewers
dsp
yuja
Group Reviewers
hg-reviewers
Summary

The test requires demandimport. Therefore enable it explicitly.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Aug 23 2017, 2:03 AM
dsp accepted this revision.Aug 24 2017, 12:53 AM

4b50e1f922a0 says something about test failures with ironpython (which I don't even know what it is) and demandimport. Maybe we should do "#require demandimport" instead to skip running the tests when it's disabled?

4b50e1f922a0 says something about test failures with ironpython (which I don't even know what it is) and demandimport. Maybe we should do "#require demandimport" instead to skip running the tests when it's disabled?

s/#require/#if/

Also, why did you even notice this? I assume because you were running with HGDEMANDIMPORT=disabled. I'm curious why you do that.

I see this test case fail every time I run the entire test suite, but not if I run it alone. I haven't debugged why yet.

I disabled demandimport because it had caused subtle issues for me in the past. Now chg also disables demandimport. Maybe the correct fix is to replace the stack trace matching to be not depend on demandimport.

In D487#8477, @quark wrote:

Maybe the correct fix is to replace the stack trace matching to be not depend on demandimport.

If demandimport is disabled, I think it fails too early (at import time, not at first use) to be relevant. So I think "#if demandimport" is the right answer. I'll send a patch.

yuja requested changes to this revision.Aug 28 2017, 9:43 AM
yuja added a subscriber: yuja.

I've queued D526 instead.

This revision now requires changes to proceed.Aug 28 2017, 9:43 AM
quark abandoned this revision.Aug 28 2017, 12:43 PM