This is an archive of the discontinued Mercurial Phabricator instance.

py3: use '%f' for floats instead of '%s'
ClosedPublic

Authored by pulkit on Oct 5 2018, 4:33 PM.

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHG2e9378f62232: py3: use '%f' for floats instead of '%s'

Summary

I remember Yuya saying we need to use bytestr() or '%r' because '%s' was clever.
Not sure it applies to this or not.

Repository

rHG Mercurial

Lint

Lint Skipped

Unit

Unit Tests Skipped

This revision was automatically updated to reflect the committed changes.

I remember Yuya saying we need to use bytestr() or '%r' because '%s' was clever.
Not sure it applies to this or not.

This should be fine since we don't care the prettiness of the debug output.

Last time, I pointed out that '%f' was incompatible since the value was a
version number, and '%f' would print it as '1.000000'.

			Path	Packages
M			mercurial/copies.py (2 lines)

Commit	Parents	Author	Summary	Date
		Pulkit Goyal		Oct 5 2018, 4:31 PM

	if debug:			if debug:
	start = util.timer()			start = util.timer()
	ofctx = _tracefile(fctx, am, limit)			ofctx = _tracefile(fctx, am, limit)
	if ofctx:			if ofctx:
	if debug:			if debug:
	dbg('debug.copies: rename of: %s\n' % ofctx._path)			dbg('debug.copies: rename of: %s\n' % ofctx._path)
	cm[f] = ofctx.path()			cm[f] = ofctx.path()
	if debug:			if debug:
	dbg('debug.copies: time: %s seconds\n'			dbg('debug.copies: time: %f seconds\n'
	% (util.timer() - start))			% (util.timer() - start))
	return cm			return cm

	def _forwardcopies(a, b, match=None):			def _forwardcopies(a, b, match=None):
	"""find {dst@b: src@a} copy mapping where a is an ancestor of b"""			"""find {dst@b: src@a} copy mapping where a is an ancestor of b"""

	# check for working copy			# check for working copy
	if b.rev() is None:			if b.rev() is None: