This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5014

py3: use %d in a few places
ClosedPublic

Authored by indygreg on Oct 12 2018, 1:25 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG113adb1b3f24: py3: use %d in a few places
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Oct 12 2018, 1:25 PM
pulkit accepted this revision.Oct 12 2018, 4:34 PM
Closed by commit rHG113adb1b3f24: py3: use %d in a few places (authored by indygreg). · Explain WhyOct 12 2018, 5:02 PM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Oct 13 2018, 12:18 AM
  • time = str(sample.time)

+ time = sample.time

stack = sample.stack
sites = ['\1'.join([s.path, str(s.lineno), s.function])
         for s in stack]
  • file.write("%s\0%s\n" % (time, '\0'.join(sites)))

+ file.write("%d\0%s\n" % (time, '\0'.join(sites)))

I guess time is a floating-point value. b"%r" can be used in which case.

Revision Contents
Changeset List

PathPackages
Mmercurial/statprof.py (8 lines)

Diff 11927

mercurial/statprof.py

save_data(statprofpath) save_data(statprofpath)
return state return state
def save_data(path): def save_data(path):
with open(path, 'w+') as file: with open(path, 'w+') as file:
file.write("%f %f\n" % state.accumulated_time) file.write("%f %f\n" % state.accumulated_time)
for sample in state.samples: for sample in state.samples:
time = str(sample.time) time = sample.time
stack = sample.stack stack = sample.stack
sites = ['\1'.join([s.path, str(s.lineno), s.function]) sites = ['\1'.join([s.path, str(s.lineno), s.function])
for s in stack] for s in stack]
file.write("%s\0%s\n" % (time, '\0'.join(sites))) file.write("%d\0%s\n" % (time, '\0'.join(sites)))
def load_data(path): def load_data(path):
lines = open(path, 'r').read().splitlines() lines = open(path, 'r').read().splitlines()
state.accumulated_time = [float(value) for value in lines[0].split()] state.accumulated_time = [float(value) for value in lines[0].split()]
state.samples = [] state.samples = []
for line in lines[1:]: for line in lines[1:]:
parts = line.split('\0') parts = line.split('\0')
function[4].sort(reverse=True, key=lambda i: i.selfseconds()) function[4].sort(reverse=True, key=lambda i: i.selfseconds())
for stat in function[4]: for stat in function[4]:
# only show line numbers for significant locations (>1% time spent) # only show line numbers for significant locations (>1% time spent)
if stat.selfpercent() > 1: if stat.selfpercent() > 1:
source = stat.site.getsource(25) source = stat.site.getsource(25)
stattuple = (stat.selfpercent(), stat.selfseconds(), stattuple = (stat.selfpercent(), stat.selfseconds(),
stat.site.lineno, source) stat.site.lineno, source)
print('%33.0f%% %6.2f line %s: %s' % (stattuple), file=fp) print('%33.0f%% %6.2f line %d: %s' % (stattuple), file=fp)
def display_about_method(data, fp, function=None, **kwargs): def display_about_method(data, fp, function=None, **kwargs):
if function is None: if function is None:
raise Exception("Invalid function") raise Exception("Invalid function")
filename = None filename = None
if ':' in function: if ':' in function:
filename, function = function.split(':') filename, function = function.split(':')
sites.reverse() sites.reverse()
line = ';'.join(sites) line = ';'.join(sites)
if line in lines: if line in lines:
lines[line] = lines[line] + 1 lines[line] = lines[line] + 1
else: else:
lines[line] = 1 lines[line] = 1
for line, count in lines.iteritems(): for line, count in lines.iteritems():
file.write("%s %s\n" % (line, count)) file.write("%s %d\n" % (line, count))
file.close() file.close()
if outputfile is None: if outputfile is None:
outputfile = '~/flamegraph.svg' outputfile = '~/flamegraph.svg'
os.system("perl ~/flamegraph.pl %s > %s" % (path, outputfile)) os.system("perl ~/flamegraph.pl %s > %s" % (path, outputfile))
print("Written to %s" % outputfile, file=fp) print("Written to %s" % outputfile, file=fp)