This is an archive of the discontinued Mercurial Phabricator instance.

pager: disable auto pager if we think it doesn't support F, R, X
AbandonedPublic

Authored by spectral on Oct 12 2018, 1:44 PM.

Details

Reviewers
baymax
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

spectral created this revision.Oct 12 2018, 1:44 PM

I need to review this on a fresher brain. But I'll be honest, I'm not sure how I feel about this.

Do you know of other programs that jump through similar hoops to properly set up a pager?

mercurial/ui.py
1120

Won't this iterate integers on Python 3?

baymax requested changes to this revision.Jan 24 2020, 12:32 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Jan 24 2020, 12:32 PM
spectral abandoned this revision.Oct 29 2021, 5:44 PM