This is an archive of the discontinued Mercurial Phabricator instance.

Differential D507

clib: update C/C++ copyright statements to pass lint checks
ClosedPublic

Authored by simpkins on Aug 24 2017, 4:39 PM.

Download Raw Diff

Details

Reviewers

quark

Group Reviewers

Restricted Project

Commits

rFBHGXee475be30487: clib: update C/C++ copyright statements to pass lint checks

Summary

Update the copyright headers in most of the C/C++ code consistently use the
GPLv2 copyright message. This allows these files to pass Facebook's internal
C/C++ linters.

Some of the files in fbcode/scm/hgext/cstore/ appear to have actually been
copied from the hg-crew repository, and were not originally authored by
Facebook. I have not modified the copyright statements in these files:

cstore/bitmanipulation.h
cstore/compat.h
cstore/mpatch.h
cstore/mpatch.c

I also have not modified any of the cfastmanifest code.

This corresponds to Facebook diff D5588677.

Test Plan

Confirmed that Facebook's C++ linters no longer complain about the copyright
messages.

Diff Detail

Repository

rFBHGX Facebook Mercurial Extensions

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

simpkins created this revision.Aug 24 2017, 4:39 PM

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 24 2017, 4:39 PM

simpkins added a child revision: D508: clib: clean up include guards in the C/C++ header files.Aug 24 2017, 4:39 PM

quark accepted this revision.Aug 24 2017, 5:48 PM

This revision is now accepted and ready to land.Aug 24 2017, 5:48 PM

Closed by commit rFBHGXee475be30487: clib: update C/C++ copyright statements to pass lint checks (authored by simpkins). · Explain WhyAug 29 2017, 12:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			cdatapack/cdatapack.h (7 lines)
M			cdatapack/cdatapack.c (7 lines)
M			cdatapack/cdatapack_dump.c (7 lines)
M			cdatapack/cdatapack_get.c (7 lines)
M			clib/buffer.h (7 lines)
M			clib/buffer.c (7 lines)
M			clib/convert.h (14 lines)
M			clib/null_test.c (7 lines)
M			clib/portability/inet.h (8 lines)
M			clib/portability/portability.h (8 lines)
M			clib/portability/unistd.h (8 lines)
M			cstore/datapackstore.h (8 lines)
M			cstore/datapackstore.cpp (8 lines)
M			cstore/key.h (8 lines)
M			cstore/match.h (10 lines)
M			cstore/py-cdatapack.h (8 lines)
M			cstore/py-cstore.cpp (8 lines)
M			cstore/py-datapackstore.h (8 lines)
M			cstore/py-structs.h (8 lines)
M			cstore/py-treemanifest.h (8 lines)
M			cstore/pythonutil.h (8 lines)
M			cstore/pythonutil.cpp (8 lines)
M			cstore/store.h (10 lines)
M			cstore/uniondatapackstore.h (8 lines)
M			cstore/uniondatapackstore.cpp (8 lines)
M			ctreemanifest/manifest.h (8 lines)
M			ctreemanifest/manifest.cpp (8 lines)
M			ctreemanifest/manifest_entry.h (8 lines)
M			ctreemanifest/manifest_entry.cpp (8 lines)
M			ctreemanifest/manifest_fetcher.h (8 lines)
M			ctreemanifest/manifest_fetcher.cpp (8 lines)
M			ctreemanifest/treemanifest.h (8 lines)
M			ctreemanifest/treemanifest.cpp (8 lines)
M			tests/test-check-code-hg.t (4 lines)

Status	Author	Revision
Closed	simpkins	D509 clib: apply clang-tidy fixes to C/C++ code
Closed	simpkins	D508 clib: clean up include guards in the C/C++ header files
Closed	simpkins	D507 clib: update C/C++ copyright statements to pass lint checks
Closed	simpkins	D506 ctreemanifest: move ManifestPtr to its own header file
Closed	simpkins	D505 clib: simplify include paths in C extensions

Diff 1402

cdatapack/cdatapack.h

	// Copyright 2016-present Facebook. All Rights Reserved.			// Copyright (c) 2004-present, Facebook, Inc.
				// All Rights Reserved.
	//			//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

	// cdatapack:			// cdatapack:
	//
	// no-check-code			// no-check-code

	#ifndef CDATAPACK_CDATAPACK_H			#ifndef CDATAPACK_CDATAPACK_H
	#define CDATAPACK_CDATAPACK_H			#define CDATAPACK_CDATAPACK_H

	#include <stdbool.h>			#include <stdbool.h>
	#include <stddef.h>			#include <stddef.h>
	#include <stdint.h>			#include <stdint.h>

cdatapack/cdatapack.c

	// Copyright 2016-present Facebook. All Rights Reserved.			// Copyright (c) 2004-present, Facebook, Inc.
				// All Rights Reserved.
	//			//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

	// cdatapack.c: Datapack implementation in C.			// cdatapack.c: Datapack implementation in C.
	//
	// no-check-code			// no-check-code

	#include "cdatapack/cdatapack.h"			#include "cdatapack/cdatapack.h"

	// be64toh is only available if _DEFAULT_SOURCE is defined for glibc >= 2.19,			// be64toh is only available if _DEFAULT_SOURCE is defined for glibc >= 2.19,
	// or _BSD_SOURCE is defined for glibc < 2.19. These have to be defined before			// or _BSD_SOURCE is defined for glibc < 2.19. These have to be defined before
	// #include <features.h>. Macros testing glibc version are defined by			// #include <features.h>. Macros testing glibc version are defined by
	// features.h, so they cannot be used here.			// features.h, so they cannot be used here.

cdatapack/cdatapack_dump.c

	// Copyright 2016-present Facebook. All Rights Reserved.			// Copyright (c) 2004-present, Facebook, Inc.
				// All Rights Reserved.
	//			//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

	// cdatapack_dump.c: Dump the entire contents of a datapack file by walking			// cdatapack_dump.c: Dump the entire contents of a datapack file by walking
	// the datapack file.			// the datapack file.
	//
	// no-check-code			// no-check-code

	#include <inttypes.h>			#include <inttypes.h>
	#include <memory.h>			#include <memory.h>
	#include <stdio.h>			#include <stdio.h>
	#include <stdlib.h>			#include <stdlib.h>

	#include "cdatapack/cdatapack.h"			#include "cdatapack/cdatapack.h"

cdatapack/cdatapack_get.c

	// Copyright 2016-present Facebook. All Rights Reserved.			// Copyright (c) 2004-present, Facebook, Inc.
				// All Rights Reserved.
	//			//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

	// cdatapack_get.c: Use the index to dump a node's delta chain.			// cdatapack_get.c: Use the index to dump a node's delta chain.
	//
	// no-check-code			// no-check-code

	#include <inttypes.h>			#include <inttypes.h>
	#include <memory.h>			#include <memory.h>
	#include <stdio.h>			#include <stdio.h>
	#include <stdlib.h>			#include <stdlib.h>

	#include "cdatapack/cdatapack.h"			#include "cdatapack/cdatapack.h"

clib/buffer.h

	// Copyright 2016-present Facebook. All Rights Reserved.			// Copyright (c) 2004-present, Facebook, Inc.
				// All Rights Reserved.
	//			//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

	// buffer.c: declarations for a generic mechanism to expand a heap-allocated			// buffer.c: declarations for a generic mechanism to expand a heap-allocated
	// buffer. this is for internal use only.			// buffer. this is for internal use only.
	//
	// no-check-code			// no-check-code

	#ifndef __FASTMANIFEST_BUFFER_H__			#ifndef __FASTMANIFEST_BUFFER_H__
	#define __FASTMANIFEST_BUFFER_H__			#define __FASTMANIFEST_BUFFER_H__

	#include <stdbool.h>			#include <stdbool.h>
	#include <stddef.h>			#include <stddef.h>
	#include <stdlib.h>			#include <stdlib.h>

clib/buffer.c

	// Copyright 2016-present Facebook. All Rights Reserved.			// Copyright (c) 2004-present, Facebook, Inc.
				// All Rights Reserved.
	//			//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

	// buffer.c: implementation for a generic mechanism to expand a heap-allocated			// buffer.c: implementation for a generic mechanism to expand a heap-allocated
	// buffer.			// buffer.
	//
	// no-check-code			// no-check-code

	#include <stdlib.h>			#include <stdlib.h>
	#include <string.h>			#include <string.h>

	#include "clib/buffer.h"			#include "clib/buffer.h"

	bool buffer_append(			bool buffer_append(

clib/convert.h

	/* convert.h - conversion utility methods			// Copyright (c) 2004-present, Facebook, Inc.
	*			// All Rights Reserved.
	* Copyright 2016 Facebook, Inc.			//
	*			// This software may be used and distributed according to the terms of the
	* This software may be used and distributed according to the terms of the			// GNU General Public License version 2 or any later version.
	* GNU General Public License version 2 or any later version. */
				// convert.h - conversion utility methods
				// no-check-code

	#ifdef __cplusplus			#ifdef __cplusplus
	#include <string>			#include <string>
	#endif			#endif

	#ifndef __CONVERT_H_C__			#ifndef __CONVERT_H_C__
	#define __CONVERT_H_C__			#define __CONVERT_H_C__

clib/null_test.c

	// Copyright 2016-present Facebook. All Rights Reserved.			// Copyright (c) 2004-present, Facebook, Inc.
				// All Rights Reserved.
	//			//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

	// null_test.c: garbage test to make CLion happy.			// null_test.c: garbage test to make CLion happy.
	//
	// no-check-code			// no-check-code

	int main(int argc, char *argv[]) {			int main(int argc, char *argv[]) {
	return 0;			return 0;
	}			}

clib/portability/inet.h

				// Copyright (c) 2004-present, Facebook, Inc.
				// All Rights Reserved.
				//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

				// no-check-code

	#ifndef PORTABILITY_INET_H			#ifndef PORTABILITY_INET_H
	#define PORTABILITY_INET_H			#define PORTABILITY_INET_H

	#if defined(_MSC_VER)			#if defined(_MSC_VER)
	#include <winsock2.h>			#include <winsock2.h>
	#pragma comment(lib, "Ws2_32.lib")			#pragma comment(lib, "Ws2_32.lib")
	/* See https://fburl.com/7hd350j8 for more details about Ws2_32.lib */			/* See https://fburl.com/7hd350j8 for more details about Ws2_32.lib */
	#else			#else
	#include <arpa/inet.h>			#include <arpa/inet.h>
	#endif			#endif

	#endif /* PORTABILITY_INET_H */			#endif /* PORTABILITY_INET_H */

clib/portability/portability.h

				// Copyright (c) 2004-present, Facebook, Inc.
				// All Rights Reserved.
				//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

				// no-check-code

	#ifndef PORTABILITY_PORTABILITY_H			#ifndef PORTABILITY_PORTABILITY_H
	#define PORTABILITY_PORTABILITY_H			#define PORTABILITY_PORTABILITY_H

	#if defined(_MSC_VER)			#if defined(_MSC_VER)
	/* MSVC2015 supports compound literals in C mode (/TC)			/* MSVC2015 supports compound literals in C mode (/TC)
	but does not support them in C++ mode (/TP) */			but does not support them in C++ mode (/TP) */
	#if defined(__cplusplus)			#if defined(__cplusplus)
	#define COMPOUND_LITERAL(typename_) typename_			#define COMPOUND_LITERAL(typename_) typename_

clib/portability/unistd.h

				// Copyright (c) 2004-present, Facebook, Inc.
				// All Rights Reserved.
				//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

				// no-check-code

	#ifndef PORTABILITY_UNISTD_H			#ifndef PORTABILITY_UNISTD_H
	#define PORTABILITY_UNISTD_H			#define PORTABILITY_UNISTD_H

	#if defined(_MSC_VER)			#if defined(_MSC_VER)
	#include <io.h>			#include <io.h>
	/* MSVC's io.h header shows deprecation			/* MSVC's io.h header shows deprecation
	warnings on these without underscore */			warnings on these without underscore */
	#define lseek _lseek			#define lseek _lseek
	#define open _open			#define open _open
	#define close _close			#define close _close
	#else			#else
	#include <unistd.h>			#include <unistd.h>
	#endif			#endif

	#endif /* PORTABILITY_UNISTD_H */			#endif /* PORTABILITY_UNISTD_H */

cstore/datapackstore.h

	// datapackstore.h - c++ declarations for a data pack store			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2017 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// datapackstore.h - c++ declarations for a data pack store
	// no-check-code			// no-check-code

	#ifndef DATAPACKSTORE_H			#ifndef DATAPACKSTORE_H
	#define DATAPACKSTORE_H			#define DATAPACKSTORE_H

	extern "C" {			extern "C" {
	#include "cdatapack/cdatapack.h"			#include "cdatapack/cdatapack.h"
	}			}

cstore/datapackstore.cpp

	// datapackstore.cpp - implementation of a datapack store			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2017 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// datapackstore.cpp - implementation of a datapack store
	// no-check-code			// no-check-code

	#include "cstore/datapackstore.h"			#include "cstore/datapackstore.h"

	#include <sys/types.h>			#include <sys/types.h>
	#include <dirent.h>			#include <dirent.h>
	#include <stdexcept>			#include <stdexcept>
	#include <stdlib.h>			#include <stdlib.h>

cstore/key.h

	// key.h - c++ declarations for a key to pack data			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2017 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// key.h - c++ declarations for a key to pack data
	// no-check-code			// no-check-code

	#ifndef KEY_H			#ifndef KEY_H
	#define KEY_H			#define KEY_H

	#include <cstring>			#include <cstring>
	#include <stdexcept>			#include <stdexcept>
	#include <vector>			#include <vector>

cstore/match.h

	// match.h - c++ declarations for a data store			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2017 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// match.h - c++ declarations for a data store
	// no-check-code			// no-check-code
	//
	#ifndef MATCH_H			#ifndef MATCH_H
	#define MATCH_H			#define MATCH_H

	class Matcher {			class Matcher {
	public:			public:
	virtual ~Matcher() {}			virtual ~Matcher() {}
	virtual bool matches(const std::string &path) = 0;			virtual bool matches(const std::string &path) = 0;
	virtual bool matches(const char *path, const size_t pathlen) = 0;			virtual bool matches(const char *path, const size_t pathlen) = 0;

cstore/py-cdatapack.h

	// py-cdatapack.h - python extension for cdatapack			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2016 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// py-cdatapack.h - python extension for cdatapack
	// no-check-code			// no-check-code

	// The PY_SSIZE_T_CLEAN define must be defined before the Python.h include,			// The PY_SSIZE_T_CLEAN define must be defined before the Python.h include,
	// as per the documentation.			// as per the documentation.
	#define PY_SSIZE_T_CLEAN			#define PY_SSIZE_T_CLEAN

	#include <arpa/inet.h>			#include <arpa/inet.h>
	#include <Python.h>			#include <Python.h>

cstore/py-cstore.cpp

	// py-cstore.cpp - C++ implementation of a store			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2016 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// py-cstore.cpp - C++ implementation of a store
	// no-check-code			// no-check-code

	// The PY_SSIZE_T_CLEAN define must be defined before the Python.h include,			// The PY_SSIZE_T_CLEAN define must be defined before the Python.h include,
	// as per the documentation.			// as per the documentation.
	#define PY_SSIZE_T_CLEAN			#define PY_SSIZE_T_CLEAN

	#include <Python.h>			#include <Python.h>

cstore/py-datapackstore.h

	// py-cstore.cpp - c++ implementation of a store			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2017 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// py-cstore.cpp - c++ implementation of a store
	// no-check-code			// no-check-code

	// The PY_SSIZE_T_CLEAN define must be defined before the Python.h include,			// The PY_SSIZE_T_CLEAN define must be defined before the Python.h include,
	// as per the documentation.			// as per the documentation.
	#define PY_SSIZE_T_CLEAN			#define PY_SSIZE_T_CLEAN
	#include <Python.h>			#include <Python.h>
	#include <memory>			#include <memory>
	#include <string>			#include <string>

cstore/py-structs.h

	// py-structs.h - c++ headers for store python objects			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2017 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// py-structs.h - c++ headers for store python objects
	// no-check-code			// no-check-code

	#ifndef CSTORE_PY_STRUCTS			#ifndef CSTORE_PY_STRUCTS
	#define CSTORE_PY_STRUCTS			#define CSTORE_PY_STRUCTS

	#include <memory>			#include <memory>

	#include "cstore/datapackstore.h"			#include "cstore/datapackstore.h"

cstore/py-treemanifest.h

	// py-treemanifest.cpp - c++ implementation of a tree manifest			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2016 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// py-treemanifest.cpp - c++ implementation of a tree manifest
	// no-check-code			// no-check-code

	// The PY_SSIZE_T_CLEAN define must be defined before the Python.h include,			// The PY_SSIZE_T_CLEAN define must be defined before the Python.h include,
	// as per the documentation.			// as per the documentation.
	#define PY_SSIZE_T_CLEAN			#define PY_SSIZE_T_CLEAN
	#include <Python.h>			#include <Python.h>
	#include <memory>			#include <memory>
	#include <string>			#include <string>

cstore/pythonutil.h

	// pythonutil.h - utilities to glue C++ code to python			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2016 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// pythonutil.h - utilities to glue C++ code to python
	// no-check-code			// no-check-code

	#ifndef REMOTEFILELOG_PYTHONOBJ_H			#ifndef REMOTEFILELOG_PYTHONOBJ_H
	#define REMOTEFILELOG_PYTHONOBJ_H			#define REMOTEFILELOG_PYTHONOBJ_H

	// The PY_SSIZE_T_CLEAN define must be defined before the Python.h include,			// The PY_SSIZE_T_CLEAN define must be defined before the Python.h include,
	// as per the documentation.			// as per the documentation.
	#define PY_SSIZE_T_CLEAN			#define PY_SSIZE_T_CLEAN

cstore/pythonutil.cpp

	// pythonutil.cpp - utilities to glue C++ code to python			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2016 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// pythonutil.cpp - utilities to glue C++ code to python
	// no-check-code			// no-check-code

	#include "pythonutil.h"			#include "pythonutil.h"

	PythonObj::PythonObj() :			PythonObj::PythonObj() :
	obj(NULL) {			obj(NULL) {
	}			}

cstore/store.h

	// store.h - c++ declarations for a data store			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2017 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// store.h - c++ declarations for a data store
	// no-check-code			// no-check-code
	//
	#ifndef STORE_H			#ifndef STORE_H
	#define STORE_H			#define STORE_H

	#include <cstddef>			#include <cstddef>
	#include <memory>			#include <memory>

	#include "cstore/key.h"			#include "cstore/key.h"

cstore/uniondatapackstore.h

	// uniondatapackstore.h - c++ declarations for a union datapack store			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2017 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// uniondatapackstore.h - c++ declarations for a union datapack store
	// no-check-code			// no-check-code

	#ifndef UNIONDATAPACKSTORE_H			#ifndef UNIONDATAPACKSTORE_H
	#define UNIONDATAPACKSTORE_H			#define UNIONDATAPACKSTORE_H

	#include <cstring>			#include <cstring>
	#include <stdexcept>			#include <stdexcept>
	#include <vector>			#include <vector>

cstore/uniondatapackstore.cpp

	// uniondatapackstore.cpp - implementation of a union datapack store			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2017 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// uniondatapackstore.cpp - implementation of a union datapack store
	// no-check-code			// no-check-code

	#include "cstore/uniondatapackstore.h"			#include "cstore/uniondatapackstore.h"

	#include <algorithm>			#include <algorithm>
	#include <memory>			#include <memory>

	extern "C" {			extern "C" {

ctreemanifest/manifest.h

	// manifest.h - c++ declarations for a single manifest			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2016 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// manifest.h - c++ declarations for a single manifest
	// no-check-code			// no-check-code

	#ifndef REMOTEFILELOG_MANIFEST_H			#ifndef REMOTEFILELOG_MANIFEST_H
	#define REMOTEFILELOG_MANIFEST_H			#define REMOTEFILELOG_MANIFEST_H

	#include <cstring>			#include <cstring>
	#include <list>			#include <list>
	#include <stdexcept>			#include <stdexcept>

ctreemanifest/manifest.cpp

	// manifest.cpp - c++ implementation of a single manifest			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2016 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// manifest.cpp - c++ implementation of a single manifest
	// no-check-code			// no-check-code

	#include "ctreemanifest/manifest.h"			#include "ctreemanifest/manifest.h"

	#include "clib/sha1.h"			#include "clib/sha1.h"

	Manifest::Manifest(ConstantStringRef &rawobj, const char *node) :			Manifest::Manifest(ConstantStringRef &rawobj, const char *node) :
	_rawobj(rawobj),			_rawobj(rawobj),

ctreemanifest/manifest_entry.h

	// manifest_entry.h - c++ declaration for a single manifest entry			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2016 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// manifest_entry.h - c++ declaration for a single manifest entry
	// no-check-code			// no-check-code

	#ifndef REMOTEFILELOG_MANIFEST_ENTRY_H			#ifndef REMOTEFILELOG_MANIFEST_ENTRY_H
	#define REMOTEFILELOG_MANIFEST_ENTRY_H			#define REMOTEFILELOG_MANIFEST_ENTRY_H

	#include <cstddef>			#include <cstddef>
	#include <cstring>			#include <cstring>
	#include <string>			#include <string>

ctreemanifest/manifest_entry.cpp

	// manifest_entry.cpp - c++ implementation of a single manifest entry			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2016 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// manifest_entry.cpp - c++ implementation of a single manifest entry
	// no-check-code			// no-check-code

	#include "ctreemanifest/manifest_entry.h"			#include "ctreemanifest/manifest_entry.h"

	#include <cassert>			#include <cassert>

	#include "ctreemanifest/manifest.h"			#include "ctreemanifest/manifest.h"

ctreemanifest/manifest_fetcher.h

	// manifest_fetcher.h - c++ declarations for a fetcher for manifests			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2016 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// manifest_fetcher.h - c++ declarations for a fetcher for manifests
	// no-check-code			// no-check-code

	#ifndef REMOTEFILELOG_MANIFEST_FETCHER_H			#ifndef REMOTEFILELOG_MANIFEST_FETCHER_H
	#define REMOTEFILELOG_MANIFEST_FETCHER_H			#define REMOTEFILELOG_MANIFEST_FETCHER_H

	#include <memory>			#include <memory>
	#include <string>			#include <string>

ctreemanifest/manifest_fetcher.cpp

	// manifest_fetcher.cpp - c++ implementation of a fetcher for manifests			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2016 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// manifest_fetcher.cpp - c++ implementation of a fetcher for manifests
	// no-check-code			// no-check-code

	#include "ctreemanifest/manifest_fetcher.h"			#include "ctreemanifest/manifest_fetcher.h"

	#include "ctreemanifest/manifest.h"			#include "ctreemanifest/manifest.h"

	ManifestFetcher::ManifestFetcher(std::shared_ptr<Store> store) :			ManifestFetcher::ManifestFetcher(std::shared_ptr<Store> store) :
	_store(store) {			_store(store) {

ctreemanifest/treemanifest.h

	// treemanifest.h - c++ declarations of a tree manifest			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2016 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// treemanifest.h - c++ declarations of a tree manifest
	// no-check-code			// no-check-code

	#ifndef REMOTEFILELOG_TREEMANIFEST_H			#ifndef REMOTEFILELOG_TREEMANIFEST_H
	#define REMOTEFILELOG_TREEMANIFEST_H			#define REMOTEFILELOG_TREEMANIFEST_H

	#include <memory>			#include <memory>
	#include <string>			#include <string>
	#include <vector>			#include <vector>

ctreemanifest/treemanifest.cpp

	// treemanifest.cpp - c++ implementation of a tree manifest			// Copyright (c) 2004-present, Facebook, Inc.
	//			// All Rights Reserved.
	// Copyright 2016 Facebook, Inc.
	//			//
	// This software may be used and distributed according to the terms of the			// This software may be used and distributed according to the terms of the
	// GNU General Public License version 2 or any later version.			// GNU General Public License version 2 or any later version.
	//
				// treemanifest.cpp - c++ implementation of a tree manifest
	// no-check-code			// no-check-code

	#include "ctreemanifest/treemanifest.h"			#include "ctreemanifest/treemanifest.h"

	#include <cassert>			#include <cassert>

	/**			/**
	* Helper function that performs the actual recursion on the tree entries.			* Helper function that performs the actual recursion on the tree entries.

tests/test-check-code-hg.t

	Skipping cfastmanifest/tree_iterator.c it has no-che?k-code (glob)			Skipping cfastmanifest/tree_iterator.c it has no-che?k-code (glob)
	Skipping cfastmanifest/tree_iterator.h it has no-che?k-code (glob)			Skipping cfastmanifest/tree_iterator.h it has no-che?k-code (glob)
	Skipping cfastmanifest/tree_iterator_test.c it has no-che?k-code (glob)			Skipping cfastmanifest/tree_iterator_test.c it has no-che?k-code (glob)
	Skipping cfastmanifest/tree_path.c it has no-che?k-code (glob)			Skipping cfastmanifest/tree_path.c it has no-che?k-code (glob)
	Skipping cfastmanifest/tree_path.h it has no-che?k-code (glob)			Skipping cfastmanifest/tree_path.h it has no-che?k-code (glob)
	Skipping cfastmanifest/tree_test.c it has no-che?k-code (glob)			Skipping cfastmanifest/tree_test.c it has no-che?k-code (glob)
	Skipping clib/buffer.c it has no-che?k-code (glob)			Skipping clib/buffer.c it has no-che?k-code (glob)
	Skipping clib/buffer.h it has no-che?k-code (glob)			Skipping clib/buffer.h it has no-che?k-code (glob)
				Skipping clib/convert.h it has no-che?k-code (glob)
	Skipping clib/null_test.c it has no-che?k-code (glob)			Skipping clib/null_test.c it has no-che?k-code (glob)
				Skipping clib/portability/inet.h it has no-che?k-code (glob)
				Skipping clib/portability/portability.h it has no-che?k-code (glob)
				Skipping clib/portability/unistd.h it has no-che?k-code (glob)
	Skipping clib/sha1.h it has no-che?k-code (glob)			Skipping clib/sha1.h it has no-che?k-code (glob)
	Skipping cstore/datapackstore.cpp it has no-che?k-code (glob)			Skipping cstore/datapackstore.cpp it has no-che?k-code (glob)
	Skipping cstore/datapackstore.h it has no-che?k-code (glob)			Skipping cstore/datapackstore.h it has no-che?k-code (glob)
	Skipping cstore/key.h it has no-che?k-code (glob)			Skipping cstore/key.h it has no-che?k-code (glob)
	Skipping cstore/match.h it has no-che?k-code (glob)			Skipping cstore/match.h it has no-che?k-code (glob)
	Skipping cstore/py-cdatapack.h it has no-che?k-code (glob)			Skipping cstore/py-cdatapack.h it has no-che?k-code (glob)
	Skipping cstore/py-cstore.cpp it has no-che?k-code (glob)			Skipping cstore/py-cstore.cpp it has no-che?k-code (glob)
	Skipping cstore/py-datapackstore.h it has no-che?k-code (glob)			Skipping cstore/py-datapackstore.h it has no-che?k-code (glob)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	1258		Aug 24 2017, 4:39 PM	★	★
Diff 2	1402	rFBHGXee475be30487611a486764bc50f0370baf3274d5	Aug 25 2017, 7:46 PM	★	★