Page MenuHomePhabricator

py3: fix test-status.t
ClosedPublic

Authored by mbthomas on Oct 13 2018, 11:32 AM.

Details

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mbthomas created this revision.Oct 13 2018, 11:32 AM
mbthomas updated this revision to Diff 12098.Oct 13 2018, 11:33 AM

Add to whitelist

pulkit added inline comments.Oct 13 2018, 11:35 AM
tests/test-status.t
540–543

are we hiding a b'' prefix here?

yuja added a subscriber: yuja.Oct 14 2018, 2:19 AM

test-status.t:540

status = [
  • {*'path': '1/2/3/4/5/b.txt'*}, (glob)

+ {*'path': *'1/2/3/4/5/b.txt'*}, (glob)

]

are we hiding a b'' prefix here?

Let's fix formatter.debugformatter.

mbthomas added inline comments.Oct 14 2018, 3:42 AM
tests/test-status.t
540–543

Yes - it's '...' on py2.7 and b'...' on py3. Is there a better way to check for these in debugoutput?

Just saw yuya's comment, I will do that.

durin42 added inline comments.
tests/test-status.t
540–543

Queued with this hunk dropped. Thanks!

This revision was automatically updated to reflect the committed changes.