This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5097

logcmdutil: add a helpful assertion to catch mistyped templates early
ClosedPublic

Authored by durin42 on Oct 14 2018, 5:40 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG96164fb9b913: logcmdutil: add a helpful assertion to catch mistyped templates early
Summary

This would have made a defect in test-notify.t much easier to figure out.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 14 2018, 5:40 AM
pulkit accepted this revision.Oct 14 2018, 6:01 AM
Closed by commit rHG96164fb9b913: logcmdutil: add a helpful assertion to catch mistyped templates early (authored by durin42). · Explain WhyOct 14 2018, 6:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/logcmdutil.py (2 lines)

Diff 12118

mercurial/logcmdutil.py

self.ui.write(self.t.render(key, props)) self.ui.write(self.t.render(key, props))
self._showpatch(ctx) self._showpatch(ctx)
if self._parts['footer']: if self._parts['footer']:
if not self.footer: if not self.footer:
self.footer = self.t.render(self._parts['footer'], props) self.footer = self.t.render(self._parts['footer'], props)
def templatespec(tmpl, mapfile): def templatespec(tmpl, mapfile):
if pycompat.ispy3:
assert not isinstance(tmpl, str), 'tmpl must not be a str'
if mapfile: if mapfile:
return formatter.templatespec('changeset', tmpl, mapfile) return formatter.templatespec('changeset', tmpl, mapfile)
else: else:
return formatter.templatespec('', tmpl, None) return formatter.templatespec('', tmpl, None)
def _lookuptemplate(ui, tmpl, style): def _lookuptemplate(ui, tmpl, style):
"""Find the template matching the given template spec or style """Find the template matching the given template spec or style