This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5114

tests: use byte literals in test-storage.py
ClosedPublic

Authored by indygreg on Oct 16 2018, 11:54 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG9b2e1b00ee94: tests: use byte literals in test-storage.py
Summary

This fixes a Python 3 breakage due to unknown key due to str/bytes type
mismatch.

  1. skip-blame just b'' literals

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Oct 16 2018, 11:54 AM
pulkit accepted this revision.Oct 16 2018, 11:55 AM
Closed by commit rHG9b2e1b00ee94: tests: use byte literals in test-storage.py (authored by indygreg). · Explain WhyOct 16 2018, 12:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-storage.py (2 lines)

Diff 12162

tests/test-storage.py

def makefilefn(self): def makefilefn(self):
"""Factory for filelog instances.""" """Factory for filelog instances."""
fl = filelog.filelog(STATE['vfs'], b'filelog-%d' % STATE['lastindex']) fl = filelog.filelog(STATE['vfs'], b'filelog-%d' % STATE['lastindex'])
STATE['lastindex'] += 1 STATE['lastindex'] += 1
return fl return fl
def maketransaction(self): def maketransaction(self):
vfsmap = {'plain': STATE['vfs'], 'store': STATE['vfs']} vfsmap = {b'plain': STATE['vfs'], b'store': STATE['vfs']}
return transaction.transaction(STATE['ui'].warn, STATE['vfs'], vfsmap, return transaction.transaction(STATE['ui'].warn, STATE['vfs'], vfsmap,
b'journal', b'undo') b'journal', b'undo')
def addrawrevision(self, fl, tr, node, p1, p2, linkrev, rawtext=None, def addrawrevision(self, fl, tr, node, p1, p2, linkrev, rawtext=None,
delta=None, censored=False, ellipsis=False, extstored=False): delta=None, censored=False, ellipsis=False, extstored=False):
flags = 0 flags = 0