( )⚙ D5120 match: fix up a repr to not crash on Python 3

This is an archive of the discontinued Mercurial Phabricator instance.

match: fix up a repr to not crash on Python 3
ClosedPublic

Authored by durin42 on Oct 16 2018, 1:13 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Oct 16 2018, 1:13 PM
pulkit accepted this revision.Oct 18 2018, 7:56 AM
This revision was automatically updated to reflect the committed changes.
martinvonz added inline comments.
mercurial/match.py
1176

sorted() seems to return a list on py3, so maybe the list() call is unnecessary?

durin42 added inline comments.Oct 18 2018, 1:51 PM
mercurial/match.py
1176

I could swear I've seen cases where it's not, but maybe we can prune this out after the freeze?

martinvonz added inline comments.Oct 18 2018, 1:53 PM
mercurial/match.py
1176

Yes, after or not at all :) I mostly pointed it out so you know for future patches (if I'm even correct about it)