This is an archive of the discontinued Mercurial Phabricator instance.

Differential D513

phabsend: print the actual URL with --confirm
ClosedPublic

Authored by quark on Aug 24 2017, 9:15 PM.

Details

Reviewers
indygreg
durin42
Group Reviewers
hg-reviewers
Commits
rHGedeb8f28c031: phabsend: print the actual URL with --confirm
Summary

Sometimes people have multiple Phabricator endpoints set in multiple repos.
It seems better for --confirm to prompt about the Phabricator endpoint
patches being sent to.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Aug 24 2017, 9:15 PM
indygreg accepted this revision.Aug 24 2017, 11:51 PM
This revision is now accepted and ready to land.Aug 24 2017, 11:51 PM
quark planned changes to this revision.Aug 24 2017, 11:59 PM
quark added inline comments.
contrib/phabricator.py
487

A wrong stack editing. I'll move url from another patch.

quark updated this revision to Diff 1274.Aug 25 2017, 12:02 AM
This revision is now accepted and ready to land.Aug 25 2017, 12:02 AM
durin42 accepted this revision.Aug 28 2017, 2:42 PM
Closed by commit rHGedeb8f28c031: phabsend: print the actual URL with --confirm (authored by quark). · Explain WhyAug 28 2017, 3:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/phabricator.py (5 lines)

Diff 1362

contrib/phabricator.py

unfi.setparents(mapping[wnode][0]) unfi.setparents(mapping[wnode][0])
# Map from "hg:meta" keys to header understood by "hg import". The order is # Map from "hg:meta" keys to header understood by "hg import". The order is
# consistent with "hg export" output. # consistent with "hg export" output.
_metanamemap = util.sortdict([(r'user', 'User'), (r'date', 'Date'), _metanamemap = util.sortdict([(r'user', 'User'), (r'date', 'Date'),
(r'node', 'Node ID'), (r'parent', 'Parent ')]) (r'node', 'Node ID'), (r'parent', 'Parent ')])
def _confirmbeforesend(repo, revs): def _confirmbeforesend(repo, revs):
url, token = readurltoken(repo)
ui = repo.ui ui = repo.ui
for rev in revs: for rev in revs:
ctx = repo[rev] ctx = repo[rev]
desc = ctx.description().splitlines()[0] desc = ctx.description().splitlines()[0]
ui.write(('%d: ' % rev), label='phabsend.revnumber') ui.write(('%d: ' % rev), label='phabsend.revnumber')
ui.write(('%s\n' % desc), label='phabsend.desc') ui.write(('%s\n' % desc), label='phabsend.desc')
if ui.promptchoice(_('Phabsend the above changes (yn)?' if ui.promptchoice(_('Send the above changes to %s (yn)?'
'$$ &Yes $$ &No')): '$$ &Yes $$ &No') % url):
quarkAuthorUnsubmitted
Not Done

A wrong stack editing. I'll move url from another patch.

quark: A wrong stack editing. I'll move `url` from another patch.
return False return False
return True return True
_knownstatusnames = {'accepted', 'needsreview', 'needsrevision', 'closed', _knownstatusnames = {'accepted', 'needsreview', 'needsrevision', 'closed',
'abandoned'} 'abandoned'}
def _getstatusname(drev): def _getstatusname(drev):