This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5198

configitems: rename the config to prevent adding an alias in future
ClosedPublic

Authored by pulkit on Oct 31 2018, 8:31 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG14b6afc6cb28: configitems: rename the config to prevent adding an alias in future
Summary

Right now the config option looks like:

[experimental.server]
stream-narrow-clones=

which does not match how config options are generally defined in core. So let's
rename this to:

[experimental]
server.stream-narrow-clones=

before the new release so that we don't have to add an alias in future for this.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Oct 31 2018, 8:31 AM
Closed by commit rHG14b6afc6cb28: configitems: rename the config to prevent adding an alias in future (authored by pulkit). · Explain WhyOct 31 2018, 8:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/bundle2.py (4 lines)
Mmercurial/configitems.py (2 lines)

Diff 12349

mercurial/bundle2.py

# goal of stream clones, which is to be fast. Communicate the desire # goal of stream clones, which is to be fast. Communicate the desire
# to avoid compression to consumers of the bundle. # to avoid compression to consumers of the bundle.
bundler.prefercompressed = False bundler.prefercompressed = False
# get the includes and excludes # get the includes and excludes
includepats = kwargs.get(r'includepats') includepats = kwargs.get(r'includepats')
excludepats = kwargs.get(r'excludepats') excludepats = kwargs.get(r'excludepats')
narrowstream = repo.ui.configbool('experimental.server', narrowstream = repo.ui.configbool('experimental',
'stream-narrow-clones') 'server.stream-narrow-clones')
if (includepats or excludepats) and not narrowstream: if (includepats or excludepats) and not narrowstream:
raise error.Abort(_('server does not support narrow stream clones')) raise error.Abort(_('server does not support narrow stream clones'))
includeobsmarkers = False includeobsmarkers = False
if repo.obsstore: if repo.obsstore:
remoteversions = obsmarkersversion(bundler.capabilities) remoteversions = obsmarkersversion(bundler.capabilities)
if not remoteversions: if not remoteversions:

mercurial/configitems.py

default=None, default=None,
) )
coreconfigitem('experimental', 'server.filesdata.recommended-batch-size', coreconfigitem('experimental', 'server.filesdata.recommended-batch-size',
default=50000, default=50000,
) )
coreconfigitem('experimental', 'server.manifestdata.recommended-batch-size', coreconfigitem('experimental', 'server.manifestdata.recommended-batch-size',
default=100000, default=100000,
) )
coreconfigitem('experimental.server', 'stream-narrow-clones', coreconfigitem('experimental', 'server.stream-narrow-clones',
default=False, default=False,
) )
coreconfigitem('experimental', 'single-head-per-branch', coreconfigitem('experimental', 'single-head-per-branch',
default=False, default=False,
) )
coreconfigitem('experimental', 'sshserver.support-v2', coreconfigitem('experimental', 'sshserver.support-v2',
default=False, default=False,
) )