Page MenuHomePhabricator

rebase: fix two ui.logs to actually have text when using default blackbox log
ClosedPublic

Authored by spectral on Nov 15 2018, 5:36 PM.

Details

Summary

Some implementations of ui.log record structured information along with the
ui.log which can be used for metrics, but ui.log() as implemented by the
blackbox logging does not do anything special with this, and we end up with a
log line with no text (not even a line break) so it ends up looking something
like:

date time user @node (pid) [rebase]> date time user @node (pid) ...

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Nov 15 2018, 5:36 PM
lothiraldan accepted this revision.Nov 16 2018, 7:58 AM
lothiraldan added a subscriber: lothiraldan.

Looks good to me, queued thanks

This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Nov 16 2018, 8:58 AM

+ self.repo.ui.log("rebase",
+ "using in-memory rebase: %r\n" % self.inmemory,

Updated as "...%r\n", self.inmemory, so string formatting wouldn't be run
unless blackbox or logtoprocess is enabled.