This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5302

py3: use pycompat.xrange instead of xrange
ClosedPublic

Authored by pulkit on Nov 26 2018, 7:56 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGba706e3082bd: py3: use pycompat.xrange instead of xrange
Summary

xrange does not exists on Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Nov 26 2018, 7:56 AM
durin42 added a subscriber: durin42.Nov 26 2018, 5:41 PM
durin42 added inline comments.
tests/test-remotefilelog-histpack.py
29

why not just use pycompat.xrange directly instead of doing extra indirection?

pulkit added inline comments.Nov 27 2018, 5:10 AM
tests/test-remotefilelog-histpack.py
29

Forgot that was a thing.

pulkit retitled this revision from py3: alias xrange to range to py3: use pycompat.xrange instead of xrange.Nov 27 2018, 5:10 AM
pulkit updated this revision to Diff 12606.
Closed by commit rHGba706e3082bd: py3: use pycompat.xrange instead of xrange (authored by pulkit). · Explain WhyNov 28 2018, 7:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12606

tests/test-remotefilelog-histpack.py

# Load the local remotefilelog, not the system one # Load the local remotefilelog, not the system one
sys.path[0:0] = [os.path.join(os.path.dirname(__file__), '..')] sys.path[0:0] = [os.path.join(os.path.dirname(__file__), '..')]
from hgext.remotefilelog import ( from hgext.remotefilelog import (
basepack, basepack,
historypack, historypack,
) )
class histpacktests(unittest.TestCase): class histpacktests(unittest.TestCase):
def setUp(self): def setUp(self):
durin42Unsubmitted
Not Done

why not just use pycompat.xrange directly instead of doing extra indirection?

durin42: why not just use pycompat.xrange directly instead of doing extra indirection?
pulkitAuthorUnsubmitted
Not Done

Forgot that was a thing.

pulkit: Forgot that was a thing.
self.tempdirs = [] self.tempdirs = []
def tearDown(self): def tearDown(self):
for d in self.tempdirs: for d in self.tempdirs:
shutil.rmtree(d) shutil.rmtree(d)
def makeTempDir(self): def makeTempDir(self):
tempdir = tempfile.mkdtemp() tempdir = tempfile.mkdtemp()
except RuntimeError: except RuntimeError:
pass pass
def testLargePack(self): def testLargePack(self):
"""Test creating and reading from a large pack with over X entries. """Test creating and reading from a large pack with over X entries.
This causes it to use a 2^16 fanout table instead.""" This causes it to use a 2^16 fanout table instead."""
total = basepack.SMALLFANOUTCUTOFF + 1 total = basepack.SMALLFANOUTCUTOFF + 1
revisions = [] revisions = []
for i in xrange(total): for i in pycompat.xrange(total):
filename = b"foo-%d" % i filename = b"foo-%d" % i
node = self.getFakeHash() node = self.getFakeHash()
p1 = self.getFakeHash() p1 = self.getFakeHash()
p2 = self.getFakeHash() p2 = self.getFakeHash()
linknode = self.getFakeHash() linknode = self.getFakeHash()
revisions.append((filename, node, p1, p2, linknode, None)) revisions.append((filename, node, p1, p2, linknode, None))
pack = self.createPack(revisions) pack = self.createPack(revisions)