This is an archive of the discontinued Mercurial Phabricator instance.

Differential D532

obsolete: clean createmarkers part about operation
ClosedPublic

Authored by lothiraldan on Aug 28 2017, 7:02 AM.

Details

Reviewers
pulkit
durin42
Group Reviewers
hg-reviewers
Commits
rHGddcef6d0b0ef: obsolete: clean createmarkers part about operation
Summary

I will add another experiment in createmarkers, add a comment and some blank
lines for aesthetic sake.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lothiraldan created this revision.Aug 28 2017, 7:02 AM
pulkit accepted this revision.Oct 1 2017, 5:26 AM
pulkit added a subscriber: pulkit.

This looks good.

durin42 accepted this revision.Oct 1 2017, 6:06 AM
This revision is now accepted and ready to land.Oct 1 2017, 6:06 AM
Closed by commit rHGddcef6d0b0ef: obsolete: clean createmarkers part about operation (authored by lothiraldan). · Explain WhyOct 1 2017, 6:55 AM
This revision was automatically updated to reflect the committed changes.
lothiraldan updated this revision to Diff 2256.Oct 1 2017, 7:51 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/obsolete.py (3 lines)

Diff 2233

mercurial/obsolete.py

This function operates within a transaction of its own, but does This function operates within a transaction of its own, but does
not take any lock on the repo. not take any lock on the repo.
""" """
# prepare metadata # prepare metadata
if metadata is None: if metadata is None:
metadata = {} metadata = {}
if 'user' not in metadata: if 'user' not in metadata:
metadata['user'] = repo.ui.username() metadata['user'] = repo.ui.username()
# Operation metadata handling
useoperation = repo.ui.configbool('experimental', useoperation = repo.ui.configbool('experimental',
'stabilization.track-operation') 'stabilization.track-operation')
if useoperation and operation: if useoperation and operation:
metadata['operation'] = operation metadata['operation'] = operation
tr = repo.transaction('add-obsolescence-marker') tr = repo.transaction('add-obsolescence-marker')
try: try:
markerargs = [] markerargs = []
for rel in relations: for rel in relations:
prec = rel[0] prec = rel[0]
sucs = rel[1] sucs = rel[1]
localmetadata = metadata.copy() localmetadata = metadata.copy()
if 2 < len(rel): if 2 < len(rel):