Page MenuHomePhabricator
Differential D543

revset: accept additional arguments for stringset
ClosedPublic
Actions

Authored by quark on Aug 28 2017, 2:09 PM.

Details

Reviewers
durham
Group Reviewers
Restricted Project
Commits
rFBHGX2ce6a458869c: revset: accept additional arguments for stringset
Summary

D451 is going to add an order parameter so let's update our code.

Also remove the wrapping of revset.symbols['stringset'], which is no
longer needed by the current Mercurial.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Aug 28 2017, 2:09 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2017, 2:09 PM
quark updated this revision to Diff 1357.Aug 28 2017, 2:16 PM
durham accepted this revision.Aug 28 2017, 7:35 PM
durham added a subscriber: durham.

I assume these have adequate test coverage to ensure this didn't break anything.

This revision is now accepted and ready to land.Aug 28 2017, 7:35 PM
ikostia added a subscriber: ikostia.Aug 31 2017, 9:45 AM
ikostia added inline comments.
hgext3rd/gitrevset.py
18

Import keyword is missing here

Closed by commit rFBHGX2ce6a458869c: revset: accept additional arguments for stringset (authored by quark). · Explain WhyAug 31 2017, 2:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext3rd/fbconduit.py (5 lines)
Mhgext3rd/gitrevset.py (24 lines)
Mhgext3rd/phrevset.py (5 lines)

Diff 1493

View Options

hgext3rd/fbconduit.py

Loading...
View Options

hgext3rd/gitrevset.py

Loading...
View Options

hgext3rd/phrevset.py

Loading...