This is an archive of the discontinued Mercurial Phabricator instance.

revset: accept additional arguments for stringset
ClosedPublic

Authored by quark on Aug 28 2017, 2:09 PM.
Tags
None
Subscribers

Details

Reviewers
durham
Group Reviewers
Restricted Project
Commits
rFBHGX2ce6a458869c: revset: accept additional arguments for stringset
Summary

D451 is going to add an order parameter so let's update our code.

Also remove the wrapping of revset.symbols['stringset'], which is no
longer needed by the current Mercurial.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Aug 28 2017, 2:09 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2017, 2:09 PM
quark updated this revision to Diff 1357.Aug 28 2017, 2:16 PM
durham accepted this revision.Aug 28 2017, 7:35 PM
durham added a subscriber: durham.

I assume these have adequate test coverage to ensure this didn't break anything.

This revision is now accepted and ready to land.Aug 28 2017, 7:35 PM
ikostia added inline comments.
hgext3rd/gitrevset.py
22

Import keyword is missing here

This revision was automatically updated to reflect the committed changes.