This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5450

rust: use .rev() for reverse range
ClosedPublic

Authored by yuja on Dec 19 2018, 9:01 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG247f51cfc668: rust: use .rev() for reverse range

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuja created this revision.Dec 19 2018, 9:01 AM
Closed by commit rHG247f51cfc668: rust: use .rev() for reverse range (authored by yuja). · Explain WhyJan 3 2019, 5:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/src/ancestors.rs (2 lines)

Diff 13001

rust/hg-core/src/ancestors.rs

let max_bases = let max_bases =
bases_visit.iter().cloned().max().unwrap_or(NULL_REVISION); bases_visit.iter().cloned().max().unwrap_or(NULL_REVISION);
let max_revs = let max_revs =
revs_visit.iter().cloned().max().unwrap_or(NULL_REVISION); revs_visit.iter().cloned().max().unwrap_or(NULL_REVISION);
let start = max(max_bases, max_revs); let start = max(max_bases, max_revs);
// TODO heuristics for with_capacity()? // TODO heuristics for with_capacity()?
let mut missing: Vec<Revision> = Vec::new(); let mut missing: Vec<Revision> = Vec::new();
for curr in (0..=start).map(|i| start - i) { for curr in (0..=start).rev() {
if revs_visit.is_empty() { if revs_visit.is_empty() {
break; break;
} }
if both_visit.contains(&curr) { if both_visit.contains(&curr) {
// curr's parents might have made it into revs_visit through // curr's parents might have made it into revs_visit through
// another path // another path
// TODO optim: Rust's HashSet.remove returns a boolean telling // TODO optim: Rust's HashSet.remove returns a boolean telling
// if it happened. This will spare us one set lookup // if it happened. This will spare us one set lookup