help: hide default value for default-off flags
ClosedPublic

Authored by martinvonz on Dec 19 2018, 12:42 PM.

Details

Summary

If we no longer show the "[no-]" for default-off flags, it also seems
unnecessary to show the "default: off" for them, since that's quite
clearly the default. It's extra confusing for action flags like `hg
bookmarks --delete`.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
martinvonz created this revision.Dec 19 2018, 12:42 PM
av6 accepted this revision.Dec 20 2018, 6:29 AM

These look good. One more thing I want to mention: hg help evolve looks like this:

   --phase-divergent   solves only phase-divergent changesets
   --content-divergent solves only content-divergent changesets
   --orphan            solves only orphan changesets (default)
-a --all               evolve all troubled changesets related to the current
                       working directory and its descendants
   --[no-]update       update to the head of evolved changesets (default: on)

--orphan line ends with (default), it's obviously just a part of the flag description, but it doesn't look too bad. I don't know if we'll end up showing "default: off" for boolean flags, but if not, then just showing (default) instead of (default: on) is an option.

This revision is now accepted and ready to land.Dec 20 2018, 6:29 AM
This revision was automatically updated to reflect the committed changes.