repository: update interface signature of narrowmatch()
ClosedPublic

Authored by martinvonz on Thu, Dec 20, 1:11 PM.

Details

Summary

This should have been part of 4fd0fac48922 (localrepo: allow
narrowmatch() to accept matcher to intersect with, 2018-09-28) and
41fcdfe3bfeb (narrow: allow repo.narrowmatch(match) to include exact
matches from "match", 2018-10-01).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
martinvonz created this revision.Thu, Dec 20, 1:11 PM
pulkit added a subscriber: pulkit.Thu, Dec 20, 1:35 PM
pulkit added inline comments.
mercurial/repository.py
1480

Maybe add docs about what these arguments are.

martinvonz added inline comments.Thu, Dec 20, 1:39 PM
mercurial/repository.py
1480

That documentation is already in localrepo.py. Is the idea to keep the same documentation in both places? I'm not objecting, just trying to understand how to handle this.

pulkit accepted this revision.Thu, Dec 20, 2:03 PM
pulkit added a subscriber: indygreg.
pulkit added inline comments.
mercurial/repository.py
1480

Ah, my bad. I am also not sure which one is better place to document. Maybe @indygreg will have ideas.

This revision was automatically updated to reflect the committed changes.

I'd say `repository.py is the best place for docs, since localrepo.py` implements the interface and the interface is what matters.