This is an archive of the discontinued Mercurial Phabricator instance.

show: use consistent (and possibly shorter) node lengths
ClosedPublic

Authored by indygreg on Aug 28 2017, 11:55 PM.

Details

Summary

hg show makes heavy use of shortest() to limit the length of the node
hash.

For the "stack" and "work" views, you are often looking at multiple
lines of similar output for "lines" of work. It is visually appeasing
for things to vertically align. A naive use of {shortest(node, N)}
could result in variable length nodes and for the first character of
the description to vary by a column or two.

We implement a function to determine the longest shortest prefix for
a set of revisions. The new function is used to determine the printed
node length for all hg show views.

.. feature::

show: use consistent node length in views

Our previous shortest node length of 5 was arbitrarily chosen.

shortest() already does the work of ensuring that a partial node
isn't ambiguous with an integer revision, which is our primary risk
of a collision for very short nodes. It should be safe to go with the
shortest node possible.

Existing code is also optimized to handle nodes as short as 4.

So, we decrease the minimum hash length from 5 to 4.

We also add a test demonstrating that prefix collisions increase the
node length.

.. feature::

show: decrease minimum displayed hash length from 5 to 4

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 28 2017, 11:55 PM
quark requested changes to this revision.Aug 29 2017, 8:04 PM
quark added a subscriber: quark.

As Yuya said in another thread. 4 is more friendly to the C code.

This revision now requires changes to proceed.Aug 29 2017, 8:04 PM
durham added a subscriber: durham.Sep 1 2017, 2:55 PM

And 4 will make the hash be unique a little longer, in case people copy old output and expect it to work on a more recent repo.

indygreg edited the summary of this revision. (Show Details)Sep 14 2017, 12:19 AM
indygreg retitled this revision from show: decrease minimum node length from 5 to 3 to show: use consistent (and possibly shorter) node lengths.
indygreg updated this revision to Diff 1811.
durham accepted this revision.Sep 14 2017, 12:33 PM
This revision was automatically updated to reflect the committed changes.