This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5602

tests: make python oneliner portable to python 3 in remotefilelog test
ClosedPublic

Authored by durin42 on Jan 16 2019, 11:16 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa495435d980e: tests: make python oneliner portable to python 3 in remotefilelog test
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 16 2019, 11:16 AM
pulkit accepted this revision.Jan 16 2019, 11:42 AM
pulkit added a subscriber: pulkit.

It's weird that print works as a function too in Python 2.

durin42 added a comment.Jan 16 2019, 11:44 AM
In D5602#82808, @pulkit wrote:

It's weird that print works as a function too in Python 2.

It's a hack: in the case of print(one_item) the parens are a noop on Python 2 and a function call on Python 3.

Closed by commit rHGa495435d980e: tests: make python oneliner portable to python 3 in remotefilelog test (authored by durin42). · Explain WhyJan 16 2019, 12:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-remotefilelog-http.t (2 lines)

Diff 13281

tests/test-remotefilelog-http.t

> EOF > EOF
$ echo x > x $ echo x > x
$ echo y > y $ echo y > y
$ hg commit -qAm x $ hg commit -qAm x
$ hg serve -p $HGPORT -d --pid-file=../hg1.pid -E ../error.log -A ../access.log $ hg serve -p $HGPORT -d --pid-file=../hg1.pid -E ../error.log -A ../access.log
Build a query string for later use: Build a query string for later use:
$ GET=`hg debugdata -m 0 | $PYTHON -c \ $ GET=`hg debugdata -m 0 | $PYTHON -c \
> 'import sys ; print [("?cmd=x_rfl_getfile&file=%s&node=%s" % tuple(s.split("\0"))) for s in sys.stdin.read().splitlines()][0]'` > 'import sys ; print([("?cmd=x_rfl_getfile&file=%s&node=%s" % tuple(s.split("\0"))) for s in sys.stdin.read().splitlines()][0])'`
$ cd .. $ cd ..
$ cat hg1.pid >> $DAEMON_PIDS $ cat hg1.pid >> $DAEMON_PIDS
$ hgcloneshallow http://localhost:$HGPORT/ shallow -q $ hgcloneshallow http://localhost:$HGPORT/ shallow -q
2 files fetched over 1 fetches - (2 misses, 0.00% hit ratio) over *s (glob) 2 files fetched over 1 fetches - (2 misses, 0.00% hit ratio) over *s (glob)
$ grep getfile access.log $ grep getfile access.log